Re: [PATCH 0/5] refactor power management into intel_pm

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Apr 16, 2012 at 10:20:33PM -0300, Eugeni Dodonov wrote:
> As Chris Wilson noticed, my previous patch that did the refactoring as one big
> patch which moved everything at once was extremely difficult to review and
> maintain. So I split the same refactoring into a series of smaller patches,
> which move one subsystem at a time.

Yeah, diffs are not actually readable, so looks like we have to do this
piece-wise. One thing that really bugs me is that we have all these
per-chip function declared as extern now, and the setup code for them is
somewhere completely different.

So can you add another patch add the end that moves all that setup code
intel intel_init_pm (at the end of intel_pm.c to avoid forward decl) and
removes all these chip-specific extern declarations?

If that patch doesn't result in only a few generic functinos exported from
intel_pm.c (and hence a simple interface) I think we need to reconsider
whether we've moved the right things in there (maybe it needs more/less).
But I can't easily judge that atm.
Yours, Daniel

> 
> As previously, this reduces the intel_display.c module by around 2800 lines
> while also simplifying future power-related developments.
> 
> 
> Eugeni Dodonov (5):
>   drm/i915: move fbc-related functionality into intel_pm module
>   drm/i915: move watermarks settings into intel_pm module
>   drm/i915: move drps, rps and rc6-related functions to intel_pm
>   drm/i915: move emon functionality into intel_pm module
>   drm/i915: move clock gating functionality into intel_pm module
> 
>  drivers/gpu/drm/i915/Makefile        |    1 +
>  drivers/gpu/drm/i915/intel_display.c | 7803 +++++++++++-----------------------
>  drivers/gpu/drm/i915/intel_drv.h     |   72 +
>  drivers/gpu/drm/i915/intel_pm.c      | 2898 +++++++++++++
>  4 files changed, 5432 insertions(+), 5342 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/intel_pm.c
> 
> -- 
> 1.7.10
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48