From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH 09/10] drm/i915: wait render timeout ioctl
Date: Sat, 21 Apr 2012 09:12:17 -0700 [thread overview]
Message-ID: <20120421091217.0897735e@bwidawsk.net> (raw)
In-Reply-To: <1335001339_11300@CP5-2952>
On Sat, 21 Apr 2012 10:41:55 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, 20 Apr 2012 18:23:31 -0700, Ben Widawsky <ben@bwidawsk.net>
> wrote:
> > + ret = i915_seqno_wait_timed(ring, seqno, true, &timeout);
> > + if (ret == -ERESTARTSYS)
> > + ret = -EINTR;
> Don't convert it here, pass ERESTARTSYS to the system call handler
> which decides how to handle it.
>
> > + else if (ret == -ETIME) {
> > + ret = -EBUSY;
>
> Why the semantic change? ETIME for timer timed out still seems
> appropriate.
I must be missing something. Can you point to me where the system call
handler converts these? The only reason for the change was to prevent
passing the internal return types to user space.
>
> I think this whole interface is a stop-gap solution for pollable sync
> objects without a clear use case. Do we have a spec for a feature
> wishing to build upon this interface?
Good point. This is primarily for glClientWaitSync. I will update the
commit message with this information.
> -Chris
>
next prev parent reply other threads:[~2012-04-21 16:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 1:23 [PATCH 00/10] wait for BO with timeout Ben Widawsky
2012-04-21 1:23 ` [PATCH 01/10] drm/i915: remove do_retire from i915_wait_request Ben Widawsky
2012-04-21 17:17 ` Daniel Vetter
2012-04-21 17:27 ` Ben Widawsky
2012-04-21 17:36 ` Daniel Vetter
2012-04-21 1:23 ` [PATCH 02/10] drm/i915: move vbetool invoked ier stuff Ben Widawsky
2012-04-21 9:26 ` Chris Wilson
2012-04-21 1:23 ` [PATCH 03/10] drm/i915: kill waiting_seqno Ben Widawsky
2012-04-22 13:46 ` Chris Wilson
2012-04-22 17:47 ` Ben Widawsky
2012-04-21 1:23 ` [PATCH 04/10] drm/i915: drop polled waits from i915_wait_request Ben Widawsky
2012-04-21 9:29 ` Chris Wilson
2012-04-21 16:14 ` Ben Widawsky
2012-04-21 1:23 ` [PATCH 05/10] drm/i915: extract __wait_seqno " Ben Widawsky
2012-04-21 1:23 ` [PATCH 06/10] drm/i915: use __wait_seqno for ring throttle Ben Widawsky
2012-04-22 14:17 ` Chris Wilson
2012-04-21 1:23 ` [PATCH 07/10] drm/i915: timeout parameter for seqno wait Ben Widawsky
2012-04-22 12:52 ` Daniel Vetter
2012-04-21 1:23 ` [PATCH 08/10] drm/i915: real wait seqno with timeout Ben Widawsky
2012-04-21 1:23 ` [PATCH 09/10] drm/i915: wait render timeout ioctl Ben Widawsky
2012-04-21 9:41 ` Chris Wilson
2012-04-21 16:12 ` Ben Widawsky [this message]
2012-04-21 20:37 ` Ben Widawsky
2012-04-22 9:37 ` Chris Wilson
2012-04-22 9:48 ` Chris Wilson
2012-04-22 10:11 ` Daniel Vetter
2012-04-22 12:45 ` Daniel Vetter
2012-04-23 15:28 ` Ben Widawsky
2012-04-22 14:14 ` Chris Wilson
2012-04-21 1:23 ` [PATCH 10/10] drm/i915: s/i915_wait_reqest/i915_wait_seqno/g Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120421091217.0897735e@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox