Re: [PATCH 0/9] i915 fixes for sparse warnings.

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Apr 16, 2012 at 02:07:39PM -0700, Ben Widawsky wrote:
> Patch 1/2 is a mix of fairly trivial stuff. I see no reason to not take
> these.
> Patch 3-9 Are all __iomem related. These should run through some
> regression testing.
> 
> Most of the __iomem stuff fell into place fairly easily, but it's
> definitely subject to a lot of copy/paste errors, since trying to
> automate the replacement didn't workout well. Throughout the patches, I
> tried really hard to not force cast things, but a couple of situations
> cropped up which gave me no choice. What I hope to achieve by that is
> there should be no functional or performance changes (aside from
> copy/paste).
> 
> I've given up on fixing intel_bios.c completely.
> 
> These are based off of dinq as of yesterday.

Ok, after some lengthy irc bikeshedding with Ben and Chris I've picked up
a few more of these, but changed a few things:
- Any hunk that touched the status_page got dropped. I've looked around
  and I think I have a plan to fix that disaster for real.
- Added comments about pointer casts due to sparse.
- Dropped the intel_bios.c patch, we agreed that to be too horrible. This
  needs some serious care to be sparse-compliant.

Thanks for digging through this mess.
-Daniel

> 
> 
> Ben Widawsky (9):
>   drm/i915: [sparse] trivial sparse fixes
>   drm/i915: [sparse] don't use variable size arrays
>   drm/i915: [sparse] __iomem fixes for opregion
>   drm/i915: [sparse] __iomem fixes for overlay
>   drm/i915: [sparse] __iomem fixes for debugfs
>   drm/i915: [sparse] __iomem fixes for ringbuffer
>   drm/i915: [sparse] forced __iomem ringbuffer fixes
>   drm/i915: [sparse] __iomem fixes for gem
>   drm/i915: [sparse] __iomem fixes for intel_bios
> 
>  drivers/gpu/drm/i915/i915_debugfs.c      |   28 ++++---
>  drivers/gpu/drm/i915/i915_drv.h          |   12 +--
>  drivers/gpu/drm/i915/i915_gem.c          |   11 +--
>  drivers/gpu/drm/i915/i915_ioc32.c        |    5 +-
>  drivers/gpu/drm/i915/i915_trace_points.c |    2 +
>  drivers/gpu/drm/i915/intel_acpi.c        |    1 +
>  drivers/gpu/drm/i915/intel_bios.c        |   20 +++--
>  drivers/gpu/drm/i915/intel_display.c     |    2 +-
>  drivers/gpu/drm/i915/intel_fb.c          |    2 +-
>  drivers/gpu/drm/i915/intel_opregion.c    |   67 ++++++++-------
>  drivers/gpu/drm/i915/intel_overlay.c     |  130 +++++++++++++++++-------------
>  drivers/gpu/drm/i915/intel_ringbuffer.c  |   28 ++++---
>  drivers/gpu/drm/i915/intel_sdvo.c        |   26 ++++--
>  13 files changed, 197 insertions(+), 137 deletions(-)
> 
> -- 
> 1.7.10
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48