From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Support pageflipping interrupts for all 3-pipes on IVB
Date: Sun, 6 May 2012 17:34:53 +0200 [thread overview]
Message-ID: <20120506153452.GA4756@phenom.ffwll.local> (raw)
In-Reply-To: <20120502124642.2ec29c9b@jbarnes-desktop>
On Wed, May 02, 2012 at 12:46:42PM -0700, Jesse Barnes wrote:
> On Wed, 2 May 2012 09:52:12 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > drivers/gpu/drm/i915/i915_irq.c | 31 ++++++++++++++++++++++---------
> > drivers/gpu/drm/i915/i915_reg.h | 7 +++++--
> > 2 files changed, 27 insertions(+), 11 deletions(-)
> >
>
> Highly embarrassing.
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Even more embarrassing that I've failed to pick this up until I've noticed
that lack of a merge conflict that should be there when mergin in -fixes.
We really need some automated tests to check whether pageflipping actually
works on all crtcs ...
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-05-06 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 8:52 [PATCH 1/2] drm/i915: Support pageflipping interrupts for all 3-pipes on IVB Chris Wilson
2012-05-02 8:52 ` [PATCH 2/2] drm/i915: Simplify the IVB interrupt handler Chris Wilson
2012-05-06 15:37 ` Daniel Vetter
2012-05-06 15:44 ` Chris Wilson
2012-05-09 20:45 ` [PATCH 1/2] drm/i915: Avoid a double-read of PCH_IIR during interrupt handling Chris Wilson
2012-05-09 20:45 ` [PATCH 2/2] drm/i915: Simplify interrupt processing for IvyBridge Chris Wilson
2012-05-10 9:56 ` Daniel Vetter
2012-05-02 19:46 ` [PATCH 1/2] drm/i915: Support pageflipping interrupts for all 3-pipes on IVB Jesse Barnes
2012-05-06 15:34 ` Daniel Vetter [this message]
2012-05-06 16:30 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506153452.GA4756@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox