Re: [PATCH 3/3] drm/i915: Replace the feature tests for BLT/BSD with ring init checks

[Ben Widawsky <ben@bwidawsk.net>]

On Fri, 11 May 2012 14:29:32 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> When userspace asks whether the driver supports the BLT or BSD rings for
> this chip, simply report whether those particular rings are initialised
> 

This was the one place where I felt HAS_BLT and HAS_BSD was sort of
nice to keep around to distinguish HW has the ring vs. HW successfully
initialized the rings.

> v2: Use intel_ring_initialized()
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_dma.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 006ea47..b0df294 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -980,10 +980,10 @@ static int i915_getparam(struct drm_device *dev, void *data,
>  		value = 1;
>  		break;
>  	case I915_PARAM_HAS_BSD:
> -		value = HAS_BSD(dev);
> +		value = intel_ring_initialized(&dev_priv->ring[VCS]);
>  		break;
>  	case I915_PARAM_HAS_BLT:
> -		value = HAS_BLT(dev);
> +		value = intel_ring_initialized(&dev_priv->ring[BCS]);
>  		break;
>  	case I915_PARAM_HAS_RELAXED_FENCING:
>  		value = 1;



-- 
Ben Widawsky, Intel Open Source Technology Center