From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/4] drm/i915: clarify preferred sdvo input mode code
Date: Tue, 22 May 2012 09:33:08 +0200 [thread overview]
Message-ID: <20120522073308.GD4672@phenom.ffwll.local> (raw)
In-Reply-To: <1334060295_345048@CP5-2952>
On Tue, Apr 10, 2012 at 01:18:13PM +0100, Chris Wilson wrote:
> On Tue, 10 Apr 2012 13:55:47 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > - kill intel_sdvo->input_dtd, it's only used as a temporary variable,
> > we store the preferred input mode in the adjusted mode at mode_fixup
> > time.
> > - rename the function to make it clear what we want it to do (get the
> > preferred mode) and say in a comment what it unfortunately does as a
> > side-effect (set the new output timings).
> >
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Patches 2-4: Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
I've queued patches 2&3 for -next, thanks for the review. I'll propably
redo patch 4 with the new constants once the interlaced fixup is merged
back into -next.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-05-22 7:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 11:55 [PATCH 0/4] sdvo hdmi regression fix and related cleanups Daniel Vetter
2012-04-10 11:55 ` [PATCH 1/4] drm/i915: handle input/output sdvo timings separately in mode_set Daniel Vetter
2012-04-10 16:17 ` Jesse Barnes
2012-04-10 16:36 ` [Intel-gfx] " Daniel Vetter
2012-04-10 16:59 ` Jesse Barnes
2012-04-10 17:13 ` [PATCH] " Daniel Vetter
2012-04-10 22:37 ` Daniel Vetter
2012-04-26 16:38 ` Daniel Vetter
2012-04-26 16:56 ` Daniel Vetter
2012-04-10 11:55 ` [PATCH 2/4] drm/i915: clarify preferred sdvo input mode code Daniel Vetter
2012-04-10 12:18 ` Chris Wilson
2012-05-22 7:33 ` Daniel Vetter [this message]
2012-04-10 11:55 ` [PATCH 3/4] drm/i915: don't silently ignore sdvo mode_set failures Daniel Vetter
2012-04-10 11:55 ` [PATCH 4/4] drm/i915: debug messge for lossy sdvo dtd -> drm mode conversion Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120522073308.GD4672@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox