From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Always update RPS interrupts thresholds along with frequency
Date: Tue, 22 May 2012 20:56:55 +0200 [thread overview]
Message-ID: <20120522185654.GE4629@phenom.ffwll.local> (raw)
In-Reply-To: <20120428191830.4cb7d464@bwidawsk.net>
On Sat, Apr 28, 2012 at 07:18:30PM -0700, Ben Widawsky wrote:
> On Sat, 28 Apr 2012 08:56:39 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > In order to avoid missed down-interrupts when coming out of RC6, it is
> > advised that we always reset the down-threshold upon a PM event. This
> > is due to that the PM unit goes through a little dance when coming
> > out of RC6, it first brings the GPU up at the lowest frequency then a
> > short time later it restores the thresholds. During that interval, the
> > down-interval may expire and the interrupt be suppressed.
> >
> > Now aware of the dance taking place within the GPU when coming out of
> > RC6, one wonders what other writes need to be queued in the fifo
> > buffer in order to be properly sequenced; setting the RP state
> > appears to be one.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44006
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> I tried really hard to review this, but it was too much. The code
> definitely is cleaner as a result, so this is:
> Acked-by: Ben Widawsky <ben@bwidawsk.net>
Picked up for -fixes with Jesse's irc r-b added, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-05-22 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 7:56 [PATCH] drm/i915: Always update RPS interrupts thresholds along with frequency Chris Wilson
2012-04-29 2:18 ` Ben Widawsky
2012-05-22 18:56 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120522185654.GE4629@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox