Re: [PATCH] drm/i915: kick any firmware framebuffers before claiming the gtt

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Jun 12, 2012 at 11:28:17AM +0200, Daniel Vetter wrote:
> Especially vesafb likes to map everything as uc- (yikes), and if that
> mapping hangs around still while we try to map the gtt as wc the
> kernel will downgrade our request to uc-, resulting in abyssal
> performance.
> 
> Unfortunately we can't do this as early as readon does (i.e. as the
> first thing we do when initializing the hw) because our fb/mmio space
> region moves around on a per-gen basis. So I've had to move it below
> the gtt initialization, but that seems to work, too. The important
> thing is that we do this before we set up the gtt wc mapping.
> 
> Now an altogether different question is why people compile their
> kernels with vesafb enabled, but I guess making things just work isn't
> bad per se ...
> 
> v2:
> - s/radeondrmfb/inteldrmfb/
> - fix up error handling
> 
> v3: Kill #ifdef X86, this is Intel after all. Noticed by Ben Widawsky.
> 
> v4: Jani Nikula complained about the pointless bool primary
> initialization.
> 
> v5: Don't oops if we can't allocate, noticed by Chris Wilson.
> 
> Reported-and-tested-by: "Kilarski, Bernard R" <bernard.r.kilarski@intel.com>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I've pushed this to dinq with Chris' irc bikeshed fixed and r-b added.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48