From: Daniel Vetter <daniel@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] Revert "drm/i915/dp: Use auxch precharge value of 5 everywhere"
Date: Fri, 15 Jun 2012 10:50:44 +0200 [thread overview]
Message-ID: <20120615084840.GA4799@phenom.ffwll.local> (raw)
In-Reply-To: <1339704900-3993-1-git-send-email-daniel.vetter@ffwll.ch>
On Thu, Jun 14, 2012 at 10:15:00PM +0200, Daniel Vetter wrote:
> This reverts commit 092945e11c5b84f66dd08f0b87fb729715d377bc.
>
> This commit prevents a DP screen from properly training the link.
> Oddly enough it works, once the machine has been warm-booted with an
> older kernel.
>
> According to DP docs this _should_ have been the right precharge time.
> Also, the commit that originally introduces this was just general snb
> DP enabling and didn't mention any specific reason for this special
> value. Whatever, trust the reporter that this makes things worse and
> let's just revert it.
>
> v2: Less spelling fail.
>
> Cc: Adam Jackson <ajax@redhat.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Reported-by: "Wouter M. Koolen" <W.M.Koolen-Wijkstra@cwi.nl>
> Buglink: https://lkml.org/lkml/2012/6/14/301
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
No one yelled around with a better idea, so I've picked this up for fixes
with cc stable.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-06-15 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 20:07 [PATCH] Revert "drm/i915/dp: Use auxch precharge value of 5 everywhere" Daniel Vetter
2012-06-14 20:15 ` Daniel Vetter
2012-06-15 8:50 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615084840.GA4799@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox