From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/3] drm/i915: fix up the IBX transcoder B check
Date: Tue, 11 Sep 2012 17:26:28 +0200 [thread overview]
Message-ID: <20120911152627.GA5500@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGSmN8PD4axWnaV06CcUezACehtQMQxHLvcjEjzQ7s2KGA@mail.gmail.com>
On Tue, Sep 11, 2012 at 11:57:56AM -0300, Paulo Zanoni wrote:
> 2012/9/10 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > This has been added in
> >
> > commit de9a35abb3b343a25065449234e47a76c4f3454a
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Tue Jun 5 11:03:40 2012 +0200
> >
> > drm/i915: assert that the IBX port transcoder select w/a is implemented
> >
> > Unfortunately I've failed to notice that these checks are not just
> > called for the port that is about to be disabled, but for all (which
> > makes sense for an assert ...), and the WARN missfired when disabling
> > another pipe than the one with the dp port.
> >
> > Hence also check whether the port is actually disabled.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54688
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Looks fine:
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Picked up for -fixes, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-09-11 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 19:58 [PATCH 0/3] Some more modeset fallout Daniel Vetter
2012-09-10 19:58 ` [PATCH 1/3] drm/i915: fix up the IBX transcoder B check Daniel Vetter
2012-09-11 14:57 ` Paulo Zanoni
2012-09-11 15:26 ` Daniel Vetter [this message]
2012-09-12 15:20 ` Jesse Barnes
2012-09-12 15:53 ` Daniel Vetter
2012-09-10 19:58 ` [PATCH 2/3] drm/i915: correctly update crtc->x/y in set_base Daniel Vetter
2012-09-12 15:29 ` Jesse Barnes
2012-09-12 15:58 ` Daniel Vetter
2012-09-10 19:58 ` [PATCH 3/3] [HACK] fix ilk/gm45 dp dpms off/on cycles Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911152627.GA5500@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox