From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: BUG() on unexpected HDMI register
Date: Tue, 25 Sep 2012 10:35:24 +0200 [thread overview]
Message-ID: <20120925083524.GC3824@bremse> (raw)
In-Reply-To: <CABVU7+vQvX8tnW5JnY52p8YtWGFOhwmz4KFoG6itTuKzRoHQAA@mail.gmail.com>
On Mon, Sep 24, 2012 at 07:12:16PM -0300, Rodrigo Vivi wrote:
> This was easy for me, feel free to use:
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Already merged to dinq before I've seen your r-b, thanks anyway for the
review (and the patch obviously too).
I've bikeshedded the actual fix a bit on irc (needs a clearer commit msg
since 32 bytes is the limit and a comment explaining what's going on).
-Daniel
>
> On Mon, Sep 24, 2012 at 10:32 AM, Paulo Zanoni <przanoni@gmail.com> wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > This should never happen, but the silent "return" makes me wonder
> > every time I try to debug InfoFrame bugs, so promote this to BUG() to
> > make sure people will complain if we ever break this.
> >
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_hdmi.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index 229897f..f9fb47c 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -377,6 +377,7 @@ static void g4x_set_infoframes(struct drm_encoder *encoder,
> > port = VIDEO_DIP_PORT_C;
> > break;
> > default:
> > + BUG();
> > return;
> > }
> >
> > @@ -435,6 +436,7 @@ static void ibx_set_infoframes(struct drm_encoder *encoder,
> > port = VIDEO_DIP_PORT_D;
> > break;
> > default:
> > + BUG();
> > return;
> > }
> >
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
> --
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-09-25 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 13:32 [PATCH 1/2] drm/i915: BUG() on unexpected HDMI register Paulo Zanoni
2012-09-24 13:32 ` [PATCH 2/2] drm/i915: make sure we write at least 32 DIP bytes Paulo Zanoni
2012-09-24 22:08 ` Rodrigo Vivi
2012-09-25 16:23 ` [PATCH] drm/i915: make sure we write all the DIP data bytes Paulo Zanoni
2012-09-25 17:06 ` Rodrigo Vivi
2012-09-26 5:50 ` Daniel Vetter
2012-09-24 22:12 ` [PATCH 1/2] drm/i915: BUG() on unexpected HDMI register Rodrigo Vivi
2012-09-25 8:35 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925083524.GC3824@bremse \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox