From: Daniel Vetter <daniel@ffwll.ch>
To: Adam Jackson <ajax@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: use adjusted_mode instead of mode for checking the 6bpc force flag
Date: Thu, 27 Sep 2012 08:42:56 +0200 [thread overview]
Message-ID: <20120927064256.GQ1980@bremse> (raw)
In-Reply-To: <1348674636.4244.26.camel@atropine>
On Wed, Sep 26, 2012 at 11:50:36AM -0400, Adam Jackson wrote:
> On Wed, 2012-09-26 at 18:43 +0300, Jani Nikula wrote:
> > The dithering introduced in
> >
> > commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf
> > Author: Adam Jackson <ajax@redhat.com>
> > Date: Tue Dec 13 15:41:00 2011 -0800
> >
> > drm/i915/dp: Dither down to 6bpc if it makes the mode fit
> >
> > stores the INTEL_MODE_DP_FORCE_6BPC flag in the private_flags of the
> > adjusted mode, while i9xx_crtc_mode_set() and ironlake_crtc_mode_set() use
> > the original mode, without the flag, so it would never have any
> > effect. However, the BPC was clamped by VBT settings, making things work by
> > coincidence, until that part was removed in
> >
> > commit 4344b813f105a19f793f1fd93ad775b784648b95
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Fri Aug 10 11:10:20 2012 +0200
> >
> > Use adjusted_mode instead of mode when checking for
> > INTEL_MODE_DP_FORCE_6BPC to make the flag have effect.
> >
> > v2: Don't forget to fix this in i9xx_crtc_mode_set() also, pointed out by
> > Daniel both before and after sending the first patch.
>
> Reviewed-by: Adam Jackson <ajax@redhat.com>
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-09-27 6:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 15:27 [PATCH] drm/i915: pass adjusted_mode instead of mode to intel_choose_pipe_bpp_dither Jani Nikula
2012-09-26 15:25 ` Daniel Vetter
2012-09-26 15:43 ` [PATCH] drm/i915: use adjusted_mode instead of mode for checking the 6bpc force flag Jani Nikula
2012-09-26 15:50 ` Adam Jackson
2012-09-27 6:42 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927064256.GQ1980@bremse \
--to=daniel@ffwll.ch \
--cc=ajax@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox