From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fixup i915_gem_object_get_page inline helper
Date: Wed, 10 Oct 2012 13:38:07 +0200 [thread overview]
Message-ID: <20121010113807.GD5533@phenom.ffwll.local> (raw)
In-Reply-To: <1349867512-22909-1-git-send-email-chris@chris-wilson.co.uk>
On Wed, Oct 10, 2012 at 12:11:52PM +0100, Chris Wilson wrote:
> Note that just because we have n == MAX elements left, does not imply
> that there are only MAX elements left in the scatterlist and so we may
> not be on the last chain, and the nth element may in fact be a chain ptr.
>
> This is exercised by the improved hangman tests and the gem_exec_big
> test in i-g-t.
>
> This regression has been introduced in
>
> commit 9da3da660d8c19a54f6e93361d147509be3fff84
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Fri Jun 1 15:20:22 2012 +0100
>
> drm/i915: Replace the array of pages with a scatterlist
>
> v2: KISS, replace the direct lookup with a for_each_sg() [danvet]
> v3: Try to be clever again.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
I've merged this one and dropped v2 from -fixes, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-10-10 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 11:11 [PATCH] drm/i915: fixup i915_gem_object_get_page inline helper Chris Wilson
2012-10-10 11:38 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-09 17:59 Daniel Vetter
2012-10-09 20:41 ` Chris Wilson
2012-10-09 20:50 ` Daniel Vetter
2012-10-09 22:16 ` Chris Wilson
2012-10-10 9:01 ` Chris Wilson
2012-10-10 9:15 ` Daniel Vetter
2012-10-10 9:21 ` Daniel Vetter
2012-10-10 10:36 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010113807.GD5533@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox