public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>, josh@joshtriplett.org
Cc: Wei Shun Chang <wei.shun.chang@intel.com>,
	intel-gfx@lists.freedesktop.org,
	Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: add LynxPoint-LP PCH ID
Date: Tue, 13 Nov 2012 00:04:53 +0100	[thread overview]
Message-ID: <20121112230453.GQ5854@phenom.ffwll.local> (raw)
In-Reply-To: <1352753653-3559-1-git-send-email-przanoni@gmail.com>

On Mon, Nov 12, 2012 at 06:54:13PM -0200, Paulo Zanoni wrote:
> From: Wei Shun Chang <wei.shun.chang@intel.com>
> 
> [pzanoni: rebase, print it's an LP PCH]
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> 
> I can't test the patch since I don't have the LP PCH.

Including Josh, since he has such a machine.
-Daniel

> 
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index f8ba5fe..418d17c 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -394,6 +394,7 @@ MODULE_DEVICE_TABLE(pci, pciidlist);
>  #define INTEL_PCH_CPT_DEVICE_ID_TYPE	0x1c00
>  #define INTEL_PCH_PPT_DEVICE_ID_TYPE	0x1e00
>  #define INTEL_PCH_LPT_DEVICE_ID_TYPE	0x8c00
> +#define INTEL_PCH_LPT_LP_DEVICE_ID_TYPE	0x9c00
>  
>  void intel_detect_pch(struct drm_device *dev)
>  {
> @@ -433,6 +434,11 @@ void intel_detect_pch(struct drm_device *dev)
>  				dev_priv->num_pch_pll = 0;
>  				DRM_DEBUG_KMS("Found LynxPoint PCH\n");
>  				WARN_ON(!IS_HASWELL(dev));
> +			} else if (id == INTEL_PCH_LPT_LP_DEVICE_ID_TYPE) {
> +				dev_priv->pch_type = PCH_LPT;
> +				dev_priv->num_pch_pll = 0;
> +				DRM_DEBUG_KMS("Found LynxPoint LP PCH\n");
> +				WARN_ON(!IS_HASWELL(dev));
>  			}
>  			BUG_ON(dev_priv->num_pch_pll > I915_NUM_PLLS);
>  		}
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2012-11-12 23:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12 20:54 [PATCH] drm/i915: add LynxPoint-LP PCH ID Paulo Zanoni
2012-11-12 23:04 ` Daniel Vetter [this message]
2012-11-12 23:24   ` Josh Triplett
2012-11-12 23:29     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121112230453.GQ5854@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=josh@joshtriplett.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=przanoni@gmail.com \
    --cc=wei.shun.chang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox