From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Reduce memory pressure during shrinker by preallocating swizzle pages
Date: Mon, 3 Dec 2012 18:29:30 +0100 [thread overview]
Message-ID: <20121203172929.GM4384@phenom.ffwll.local> (raw)
In-Reply-To: <1354552259-20069-1-git-send-email-chris@chris-wilson.co.uk>
On Mon, Dec 03, 2012 at 04:30:59PM +0000, Chris Wilson wrote:
> On a machine with bit17 swizzling, we need to store the bit17 of the
> physical page address in put-pages. This requires a memory allocation,
> on average less than a page, which may be difficult to satisfy is the
> request to put-pages is on behalf of the shrinker. We could allow that
> allocation to pull from the reserved memory pools, but it seems much
> safer to preallocate the array for tiled objects on affected machines.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/i915_gem_tiling.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_tiling.c b/drivers/gpu/drm/i915/i915_gem_tiling.c
> index 8e59bb5..140ef6b 100644
> --- a/drivers/gpu/drm/i915/i915_gem_tiling.c
> +++ b/drivers/gpu/drm/i915/i915_gem_tiling.c
> @@ -351,6 +351,20 @@ i915_gem_set_tiling(struct drm_device *dev, void *data,
> /* we have to maintain this existing ABI... */
> args->stride = obj->stride;
> args->tiling_mode = obj->tiling_mode;
> +
> + /* Try to preallocate memory required to save swizzling on put-pages */
> + if (dev_priv->mm.bit_6_swizzle_x == I915_BIT_6_SWIZZLE_9_10_17) {
> + if (obj->tiling_mode) {
i915_gem_object_needs_bit17_swizzle not suitable?
-Daniel
> + if (obj->bit_17 == NULL) {
> + obj->bit_17 = kmalloc(BITS_TO_LONGS(obj->base.size >> PAGE_SHIFT) *
> + sizeof(long), GFP_KERNEL);
> + }
> + } else {
> + kfree(obj->bit_17);
> + obj->bit_17 = NULL;
> + }
> + }
> +
> drm_gem_object_unreference(&obj->base);
> mutex_unlock(&dev->struct_mutex);
>
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-12-03 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 16:30 [PATCH] drm/i915: Reduce memory pressure during shrinker by preallocating swizzle pages Chris Wilson
2012-12-03 17:29 ` Daniel Vetter [this message]
2012-12-03 17:54 ` Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2012-12-03 19:18 [PATCH 09/14] drm/i915: Remove check for conflicting relocation write-domains Daniel Vetter
2012-12-03 21:03 ` [PATCH] drm/i915: Reduce memory pressure during shrinker by preallocating swizzle pages Chris Wilson
2012-12-07 0:16 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203172929.GM4384@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox