From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Clear the existing watermarks for g4x when modifying the cursor sr
Date: Tue, 4 Dec 2012 22:44:25 +0100 [thread overview]
Message-ID: <20121204214425.GF11556@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGTq6-n82hTcREM3CJT-RZei=mqGubajz0zrEkKPcdkpug@mail.gmail.com>
On Tue, Dec 04, 2012 at 05:48:53PM -0200, Paulo Zanoni wrote:
> Hi
>
> 2012/12/4 Chris Wilson <chris@chris-wilson.co.uk>:
> > In a couple of places we attempt to adjust the existing watermark
> > registers to update them for the new cursor watermarks. This goes
> > horribly wrong as instead of clearing the cursor bits prior to or'ing in
> > the new values, we clear the rest of the register with the result that
> > the watermark registers contain bogus values.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=47034
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Nice catch...
Indeed. Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-12-04 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 16:33 [PATCH] drm/i915: Clear the existing watermarks for g4x when modifying the cursor sr Chris Wilson
2012-12-04 19:48 ` Paulo Zanoni
2012-12-04 21:44 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204214425.GF11556@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox