From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Implement workaround for broken CS tlb on i830/845
Date: Mon, 17 Dec 2012 14:43:03 +0100 [thread overview]
Message-ID: <20121217134303.GO5737@phenom.ffwll.local> (raw)
In-Reply-To: <6c3329$7mbtk2@orsmga002.jf.intel.com>
On Mon, Dec 17, 2012 at 01:33:01PM +0000, Chris Wilson wrote:
> On Sun, 16 Dec 2012 22:46:00 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > @@ -1087,6 +1087,9 @@ i915_error_first_batchbuffer(struct drm_i915_private *dev_priv,
> > if (!ring->get_seqno)
> > return NULL;
> >
> > + if (HAS_BROKEN_CS_TLB(dev_priv->dev))
> > + return i915_error_object_create(dev_priv, ring->private);
>
> Hmm, this is complicated by userspace opting out of the CS w/a, and
> imposes quite a burden upon our simple seq interface.
Right, I've written this without userspace being able to opt out in mind
... for the seq -ENOMEM, I guess it's just time to bite the bullet. Loads
of the error_states for the ilk fallout couldn't be dumped (but could be
captured) by bug reporters already :(
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-12-17 13:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 22:46 [PATCH] drm/i915: Implement workaround for broken CS tlb on i830/845 Chris Wilson
2012-12-17 13:33 ` Chris Wilson
2012-12-17 13:43 ` Daniel Vetter [this message]
2012-12-17 14:46 ` Ville Syrjälä
2012-12-17 15:12 ` Daniel Vetter
2012-12-17 15:39 ` Ville Syrjälä
2012-12-17 15:18 ` Chris Wilson
2012-12-17 15:23 ` Chris Wilson
2012-12-17 15:30 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2012-12-16 17:08 Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217134303.GO5737@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox