From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
linux-fbdev-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: fixup per-crtc locking in intel_release_load_detect_pipe
Date: Thu, 24 Jan 2013 10:55:12 +0100 [thread overview]
Message-ID: <20130124095512.GU31870@phenom.ffwll.local> (raw)
In-Reply-To: <1358958309-5342-3-git-send-email-daniel.vetter@ffwll.ch>
On Wed, Jan 23, 2013 at 05:25:09PM +0100, Daniel Vetter wrote:
> One of the early return cases missed the mutex unlocking. Hilarity
> ensued.
>
> This regression has been introduced in
>
> commit 7b24056be6db7ce907baffdd4cf142ab774ea60c
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Wed Dec 12 00:35:33 2012 +0100
>
> drm: don't hold crtc mutexes for connector ->detect callbacks
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59750
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Tested-by: Cancan Feng <cancan.feng@intel.com>
Dave, please pick this one up for your drm-next tree since the issue only
happens there due to the modeset locking rework.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-01-24 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 16:25 [PATCH 0/2] fbcon+i915 locking fixes Daniel Vetter
2013-01-23 16:25 ` [PATCH 1/2] fb: Rework locking to fix lock ordering on takeover Daniel Vetter
2013-01-23 16:38 ` Takashi Iwai
2013-01-23 16:49 ` Daniel Vetter
2013-01-23 16:25 ` [PATCH 2/2] drm/i915: fixup per-crtc locking in intel_release_load_detect_pipe Daniel Vetter
2013-01-24 9:55 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124095512.GU31870@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox