From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] intel_chipset: Merge igt chipsets
Date: Mon, 11 Feb 2013 15:05:19 -0800 [thread overview]
Message-ID: <20130211150519.56508ec7@jbarnes-desktop> (raw)
In-Reply-To: <1360518897-9490-1-git-send-email-ben@bwidawsk.net>
On Sun, 10 Feb 2013 09:54:57 -0800
Ben Widawsky <ben@bwidawsk.net> wrote:
> IGT is newer and arguably better. This change doesn't completely merge
> the files because it's a bit simpler if we move the I9XX macro over to
> IGT, and don't move over a few macros from IGT that libdrm doesn't care
> about.
>
> The advantage is being able to easily synchronize between the two
> definitions.
>
> It has been discussed, and would seem even easier if IGT simply used the
> libdrm header files, however since we want to keep IGT as isolated as
> possible, and many tests don't rely on libdrm, this isn't a good idea.
>
> This patch has been sitting around on an internal tree for a while, but
> because Jesse recently pushed VLV ID updates it painfully made me
> realize that I should probably try to upstream it sooner rather than
> later.
>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
Yeah it's fine with me. Making merging less painful and spurious
differences fewer is an improvement.
However, consolidating our PCI ID lists would be the best
option. If we can't use libdrm for that, what should we use?
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-02-11 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 17:54 [PATCH] intel_chipset: Merge igt chipsets Ben Widawsky
2013-02-11 23:05 ` Jesse Barnes [this message]
2013-02-11 23:14 ` Ben Widawsky
2013-02-11 23:05 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211150519.56508ec7@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox