From: Chris Wilson <chris@chris-wilson.co.uk>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: don't clflush gem objects in stolen memory
Date: Wed, 13 Feb 2013 20:39:58 +0000 [thread overview]
Message-ID: <20130213203958.GA32075@cantiga.alporthouse.com> (raw)
In-Reply-To: <1360785365-5628-1-git-send-email-imre.deak@intel.com>
On Wed, Feb 13, 2013 at 09:56:05PM +0200, Imre Deak wrote:
> As explained by Chris Wilson gem objects in stolen memory are always
> coherent with the GPU so we don't need to ever flush the CPU caches for
> these.
>
> This fixes a breakage - at least with the compact sg patches applied -
> during the resume/restore gtt mappings path, when we tried to clflush an
> FB object in stolen memory, but since stolen objects don't have backing
> pages we passed an invalid page pointer to drm_clflush_page().
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
To the best of my knowledge, this is correct:
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Though the stolen framework landed in 3.8, tough call as to whether this
should be in 3.8 as well given the backported clflush fix... I guess we
are simply too late, so drm-intel-next +
Cc: stable@vger.kernel.org
Imre do you mind digging up the sha of both the introduction of stolen
and the clflush of unbounded upon resume?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-02-13 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 19:56 [PATCH] drm/i915: don't clflush gem objects in stolen memory Imre Deak
2013-02-13 20:39 ` Chris Wilson [this message]
2013-02-13 20:55 ` Imre Deak
2013-02-13 21:41 ` Chris Wilson
2013-02-13 21:11 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213203958.GA32075@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox