From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/i915: don't restore LVDS enable state blindly
Date: Fri, 15 Feb 2013 13:15:10 -0800 [thread overview]
Message-ID: <20130215131510.5c32a290@jbarnes-desktop> (raw)
In-Reply-To: <20130215211039.GH5813@phenom.ffwll.local>
On Fri, 15 Feb 2013 22:10:39 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Feb 15, 2013 at 12:42:32PM -0800, Jesse Barnes wrote:
> > We still rely on a few LVDS bits, but restoring the enable bit can cause
> > trouble at this point, so don't.
> >
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > ---
> > drivers/gpu/drm/i915/i915_suspend.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c
> > index 2135f21..a81abed 100644
> > --- a/drivers/gpu/drm/i915/i915_suspend.c
> > +++ b/drivers/gpu/drm/i915/i915_suspend.c
> > @@ -268,9 +268,9 @@ static void i915_restore_display(struct drm_device *dev)
> > I915_WRITE(BLC_PWM_CTL2, dev_priv->regfile.saveBLC_PWM_CTL2);
> >
> > if (HAS_PCH_SPLIT(dev)) {
> > - I915_WRITE(PCH_LVDS, dev_priv->regfile.saveLVDS);
> > + I915_WRITE(PCH_LVDS, dev_priv->regfile.saveLVDS & 0x7fffffff);
>
> ~LVDS_PORT_EN and I think you need to make this conditional on kms.
> -Daniel
Good call, will respin.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-02-15 21:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 20:42 VT switchless resume patches Jesse Barnes
2013-02-15 20:42 ` [PATCH 1/6] drm/i915: don't restore LVDS enable state blindly Jesse Barnes
2013-02-15 21:10 ` Daniel Vetter
2013-02-15 21:15 ` Jesse Barnes [this message]
2013-02-15 20:42 ` [PATCH 2/6] drm/i915: add sprite restore function Jesse Barnes
2013-02-15 20:42 ` [PATCH 3/6] drm/i915: restore cursor and sprite state when forcing a config restore Jesse Barnes
2013-02-15 20:42 ` [PATCH 4/6] drm/i915: enable VT switchless resume Jesse Barnes
2013-02-15 21:14 ` Daniel Vetter
2013-02-15 20:42 ` [PATCH 5/6] drm/i915: emit a hotplug event on resume Jesse Barnes
2013-02-15 20:42 ` [PATCH 6/6] drm/i915: remove disabled memset of framebuffer from intel_fb Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2013-02-15 21:07 VT switchless resume v2 Jesse Barnes
2013-02-15 21:07 ` [PATCH 1/6] drm/i915: don't restore LVDS enable state blindly Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215131510.5c32a290@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox