From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Always call fence-lost prior to removing the fence
Date: Tue, 26 Mar 2013 20:21:24 +0100 [thread overview]
Message-ID: <20130326192123.GX9021@phenom.ffwll.local> (raw)
In-Reply-To: <1364307958.2358.3.camel@intelbox>
On Tue, Mar 26, 2013 at 04:25:58PM +0200, Imre Deak wrote:
> On Tue, 2013-03-26 at 11:29 +0000, Chris Wilson wrote:
> > There is a minute window for a race between put-fence removing the fence
> > and for a new transaction by an external party on the GTT mmap. That is
> > we must zap the mmap prior to removing the fence and not afterwards.
> >
> > Fixes regression from
> > commit 61050808bb019ebea966b7b5bfd357aaf219fb51
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date: Tue Apr 17 15:31:31 2012 +0100
> >
> > drm/i915: Refactor put_fence() to use the common fence writing routine
> >
> > v2: Remember the fence to remove with a local variable (gcc)
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: stable@vger.kernel.org # regression introduced in v3.5
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
stable rules say "no theoretical races", and I think we don't even have a
testcase for this. Hence queued for -next and dropped cc: stable, thanks
for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-03-26 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 10:39 [PATCH] drm/i915: Always call fence-lost prior to removing the fence Chris Wilson
2013-03-26 11:29 ` Chris Wilson
2013-03-26 14:25 ` [Intel-gfx] " Imre Deak
2013-03-26 19:21 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326192123.GX9021@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox