From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Wait for vblank between disabling a sprite and unpinning the fb
Date: Wed, 27 Mar 2013 09:29:03 -0700 [thread overview]
Message-ID: <20130327092903.1fe30906@jbarnes-desktop> (raw)
In-Reply-To: <1364399353-24486-1-git-send-email-ville.syrjala@linux.intel.com>
On Wed, 27 Mar 2013 17:49:13 +0200
ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> When disabling a sprite, wait for the sprite to stop fetching data
> from memory before unpinning the fb.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_sprite.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 414d325..27df5b8 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -582,6 +582,8 @@ intel_disable_plane(struct drm_plane *plane)
> if (!intel_plane->obj)
> goto out;
>
> + intel_wait_for_vblank(dev, intel_plane->pipe);
> +
> mutex_lock(&dev->struct_mutex);
> intel_unpin_fb_obj(intel_plane->obj);
> intel_plane->obj = NULL;
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-03-27 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 15:49 [PATCH] drm/i915: Wait for vblank between disabling a sprite and unpinning the fb ville.syrjala
2013-03-27 16:29 ` Jesse Barnes [this message]
2013-03-27 16:48 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327092903.1fe30906@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox