From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: clear crt hotplug compare voltage field before setting
Date: Wed, 27 Mar 2013 17:02:43 +0200 [thread overview]
Message-ID: <20130327150243.GC4469@intel.com> (raw)
In-Reply-To: <1364395631-27934-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, Mar 27, 2013 at 03:47:11PM +0100, Daniel Vetter wrote:
> Noticed while reviewing the hotplug irq setup code. Just looks better.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
What about the activation period? Do we want to leave it alone on non
g4x platforms, or should it also get cleared?
> ---
> drivers/gpu/drm/i915/i915_irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index c697580..be2d6dd 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2776,6 +2776,7 @@ static void i915_hpd_irq_setup(struct drm_device *dev)
> */
> if (IS_G4X(dev))
> hotplug_en |= CRT_HOTPLUG_ACTIVATION_PERIOD_64;
> + hotplug_en &= ~CRT_HOTPLUG_VOLTAGE_COMPARE_MASK;
> hotplug_en |= CRT_HOTPLUG_VOLTAGE_COMPARE_50;
>
> /* Ignore TV since it's buggy */
> --
> 1.7.11.7
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-03-27 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 23:44 [PATCH] drm/i915: implement ibx_hpd_irq_setup Daniel Vetter
2013-03-27 14:03 ` Ville Syrjälä
2013-03-27 14:47 ` [PATCH] drm/i915: clear crt hotplug compare voltage field before setting Daniel Vetter
2013-03-27 15:02 ` Ville Syrjälä [this message]
2013-03-27 15:41 ` Daniel Vetter
2013-03-27 14:55 ` [PATCH] drm/i915: implement ibx_hpd_irq_setup Daniel Vetter
2013-03-27 15:05 ` Ville Syrjälä
2013-03-27 15:42 ` Daniel Vetter
2013-03-29 16:35 ` Egbert Eich
2013-04-01 18:13 ` Daniel Vetter
2013-04-02 8:49 ` Egbert Eich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327150243.GC4469@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox