From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion
Date: Tue, 2 Apr 2013 13:49:10 -0700 [thread overview]
Message-ID: <20130402134910.7483509c@jbarnes-desktop> (raw)
In-Reply-To: <20130402134752.6207a0a9@jbarnes-desktop>
On Tue, 2 Apr 2013 13:47:52 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Thu, 28 Mar 2013 10:41:56 +0100
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> >
> > + /* DP has a bunch of special case unfortunately, so mark the pipe
> > + * accordingly. */
> > + bool has_dp_encoder;
>
> Looks pretty good, but I don't think this field is used anywhere?
> Maybe it belongs in a later patch?
>
> Also, this makes me wonder if we should be clearing the m_n regs
> somewhere and asserting for them in a few places.
>
> Definitely looks better than the current code though; CPU vs PCH writes
> sprinkled all about, and FDI thrown into the mix.
>
> It's probably a bit unfair to say the HSW mode set is confused though;
> it's just using existing code as best it can. These new bits are
> definitely clearer though.
>
Oh and with the new field moved to another patch:
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-04-02 20:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 9:41 [PATCH 0/8] dp/fdi m/n rework + basic pipe_config readout Daniel Vetter
2013-03-28 9:41 ` [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion Daniel Vetter
2013-04-02 20:47 ` Jesse Barnes
2013-04-02 20:49 ` Jesse Barnes [this message]
2013-04-02 21:38 ` [PATCH] " Daniel Vetter
2013-03-28 9:41 ` [PATCH 2/8] drm/i915: move dp_m_n computation to dp_encoder->compute_config Daniel Vetter
2013-04-02 20:51 ` Jesse Barnes
2013-04-02 21:42 ` [PATCH] " Daniel Vetter
2013-03-28 9:41 ` [PATCH 3/8] drm/i915: track dp target_clock in pipe_config Daniel Vetter
2013-04-02 20:56 ` Jesse Barnes
2013-04-02 21:27 ` [PATCH] drm/i915: remove leaky eDP functions Daniel Vetter
2013-04-02 21:30 ` Jesse Barnes
2013-03-28 9:41 ` [PATCH 4/8] drm/i915: rip out superflous is_dp&is_cpu_edp tracking Daniel Vetter
2013-04-02 21:01 ` Jesse Barnes
2013-03-28 9:42 ` [PATCH 5/8] drm/i915: add hw state readout/checking for pipe_config Daniel Vetter
2013-04-02 21:05 ` Jesse Barnes
2013-03-28 9:42 ` [PATCH 6/8] drm/i915: hw readout support for ->has_pch_encoders Daniel Vetter
2013-04-02 21:08 ` Jesse Barnes
2013-03-28 9:42 ` [PATCH 7/8] drm/i915: create pipe_config->dpll for clock state Daniel Vetter
2013-04-02 21:14 ` Jesse Barnes
2013-04-03 9:44 ` Daniel Vetter
2013-03-28 9:42 ` [PATCH 8/8] drm/i915: move dp clock computations to encoder->compute_config Daniel Vetter
2013-04-02 21:20 ` Jesse Barnes
2013-04-02 21:26 ` Daniel Vetter
2013-04-05 18:51 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2013-02-22 0:04 [PATCH 00/10] bpc handling fixes Daniel Vetter
2013-02-22 0:04 ` [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion Daniel Vetter
2013-02-22 0:00 [PATCH 0/8] fdi/dp m_n reorg and a few other clock changes Daniel Vetter
2013-02-22 0:00 ` [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402134910.7483509c@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox