From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: The timeout for wait_timeout_ioctl is only valid upon success
Date: Tue, 9 Apr 2013 11:07:40 +0200 [thread overview]
Message-ID: <20130409090740.GT2228@phenom.ffwll.local> (raw)
In-Reply-To: <1365497895-16272-1-git-send-email-chris@chris-wilson.co.uk>
On Tue, Apr 09, 2013 at 09:58:15AM +0100, Chris Wilson wrote:
> As we only update and sanitize the return timeout value after a
> successful wait, we should not assert that it is valid for any error
> returns. Also, for consistency, we should only modify args->timeout_ns
> upon success.
Doesn't that break our -EAGAIN trickery?
-Daniel
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 63c05dd..da78cf7 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -2377,7 +2377,7 @@ i915_gem_wait_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
> mutex_unlock(&dev->struct_mutex);
>
> ret = __wait_seqno(ring, seqno, reset_counter, true, timeout);
> - if (timeout) {
> + if (ret == 0 && timeout) {
> WARN_ON(!timespec_valid(timeout));
> args->timeout_ns = timespec_to_ns(timeout);
> }
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-04-09 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 8:58 [PATCH] drm/i915: The timeout for wait_timeout_ioctl is only valid upon success Chris Wilson
2013-04-09 9:07 ` Daniel Vetter [this message]
2013-04-09 9:13 ` [PATCH] drm/i915: Always normalize return timeout for wait_timeout_ioctl Chris Wilson
2013-04-09 9:26 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409090740.GT2228@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox