From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Always normalize return timeout for wait_timeout_ioctl
Date: Tue, 30 Apr 2013 10:50:56 +0200 [thread overview]
Message-ID: <20130430085056.GE6169@phenom.ffwll.local> (raw)
In-Reply-To: <20130427195133.GA13526@bwidawsk.net>
On Sat, Apr 27, 2013 at 12:51:33PM -0700, Ben Widawsky wrote:
> On Fri, Apr 26, 2013 at 04:22:46PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > As we recompute the remaining timeout after waiting, there is a
> > potential for that timeout to be less than zero and so need sanitizing.
> > The timeout is always returned to userspace and validated, so we should
> > always perform the sanitation.
> >
> > v2 [vsyrjala]: Only normalize the timespec if it's invalid
> > v3: Add a comment to clarify the situation and remove the now
> > useless WARN_ON() (ickle)
> >
> > Cc: Ben Widawsky <ben@bwidawsk.net>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This does an excellent job of removing the warnings I'd sometimes see.
>
> Unfortunately I've confirmed I can still reproduce the hang, and now
> with no errors to leave any clues. I can't promise, but I'm 75%ish
> certain I'd not always see a WARN before too (in fact I think that was
> the case when Chris wrote the original patch)
>
> The frequency with which I see the hangs seem to be increasing as well.
> Does nobody else see this? I will have to take a shot at getting more
> info.
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-04-30 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 13:09 [PATCH v2] drm/i915: Always normalize return timeout for wait_timeout_ioctl ville.syrjala
2013-04-26 13:22 ` [PATCH v3] " ville.syrjala
2013-04-27 19:51 ` Ben Widawsky
2013-04-30 8:50 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430085056.GE6169@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox