From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Xiong Zhang <xiong.y.zhang@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: set active format aspect ratio same as picture aspect ratio
Date: Wed, 22 May 2013 13:10:00 +0300 [thread overview]
Message-ID: <20130522101000.GB28346@intel.com> (raw)
In-Reply-To: <1369212495-29566-1-git-send-email-xiong.y.zhang@intel.com>
On Wed, May 22, 2013 at 04:48:15PM +0800, Xiong Zhang wrote:
> HDMI Compliance Testing fail on i915 driver, the error log show:
> M1-M0=0b00(NO Data) of AVI InfoFrame Packet should correspond to the
> aspect ratio of the viewed image.Skip because AVI R3-R0 is no 1000
> (Same as picture aspect ratio)
>
> the default value of active format aspect ratio is 0 which is invalid
> accroding to CEA-861-D spec in page 79, So change the default value to
> 0x08.
If you look at Annex H, 0000 should actually be allowed. But since it
should be interpreted the same as 1000, I guess we might as well make
this change.
Also, please change intel_sdvo.c too.
>
> Signed-off-by: Xiong Zhang <xiong.y.zhang@intel.com>
> ---
> drivers/gpu/drm/i915/intel_drv.h | 1 +
> drivers/gpu/drm/i915/intel_hdmi.c | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 75a7f22..91b345e 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -370,6 +370,7 @@ struct cxsr_latency {
> #define DIP_TYPE_AVI 0x82
> #define DIP_VERSION_AVI 0x2
> #define DIP_LEN_AVI 13
> +#define DIP_AVI_FORMAT_ASPECT_RATIO_SAME 0x8
> #define DIP_AVI_PR_1 0
> #define DIP_AVI_PR_2 1
> #define DIP_AVI_RGB_QUANT_RANGE_DEFAULT (0 << 2)
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 18f8ce0..599c013 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -340,6 +340,11 @@ static void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder,
> .len = DIP_LEN_AVI,
> };
>
> + /*since the default picture aspect ratio is no data
> + *set the default active format aspect ratio is the
> + *same as picture aspect ratio*/
> + avi_if.body.avi.C_M_R = DIP_AVI_FORMAT_ASPECT_RATIO_SAME;
> +
> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK)
> avi_if.body.avi.YQ_CN_PR |= DIP_AVI_PR_2;
>
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-05-22 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 8:48 [PATCH] drm/i915: set active format aspect ratio same as picture aspect ratio Xiong Zhang
2013-05-22 9:07 ` Daniel Vetter
2013-05-22 10:10 ` Ville Syrjälä [this message]
2013-10-17 16:43 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522101000.GB28346@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=xiong.y.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox