Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: rip out the PM_IIR WARN, again
Date: Fri, 31 May 2013 19:21:43 +0200	[thread overview]
Message-ID: <20130531172143.GA15743@phenom.ffwll.local> (raw)
In-Reply-To: <20130531152207.GV15743@phenom.ffwll.local>

On Fri, May 31, 2013 at 05:22:07PM +0200, Daniel Vetter wrote:
> On Fri, May 31, 2013 at 04:11:59PM +0100, Damien Lespiau wrote:
> > On Fri, May 31, 2013 at 09:12:19AM +0200, Daniel Vetter wrote:
> > > This has accidentally been reintroduced with
> > > 
> > > commit 22aae764a3fa21ee502b99e8986cb4e49ec14cfe
> > > Author:     Ben Widawsky <ben@bwidawsk.net>
> > > Date: Tue May 28 19:22:24 2013 -0700
> > > 
> > >     drm/i915: Create a more generic pm handler for hsw+
> > > 
> > > See
> > > 
> > > commit 58bf8062d0b293b8e1028e5b0342082002886bd4
> > > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Date:   Thu Jun 21 14:55:22 2012 +0200
> > > 
> > >     drm/i915: rip out the PM_IIR WARN
> > > 
> > > for the extensive reasoning why the WARN is bogus.
> > > 
> > > Cc: Damien Lespiau <damien.lespiau@intel.com>
> > > Cc: Ben Widawsky <ben@bwidawsk.net>
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65197
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > ---
> > >  drivers/gpu/drm/i915/i915_irq.c |    7 ++-----
> > >  1 file changed, 2 insertions(+), 5 deletions(-)
> > 
> > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> > 
> > There's a conflict with the rest of the VECS series, but fortunately
> > seems like an easy one.
> 
> Queued for -next, thanks for the review.

Patch dropped again since totally bogus.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      reply	other threads:[~2013-05-31 17:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31  7:12 [PATCH] drm/i915: rip out the PM_IIR WARN, again Daniel Vetter
2013-05-31 15:11 ` Damien Lespiau
2013-05-31 15:22   ` Daniel Vetter
2013-05-31 17:21     ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130531172143.GA15743@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=ben@bwidawsk.net \
    --cc=damien.lespiau@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox