Re: [PATCH 5/9] drm/i915: Drop overlay DPMS call from valleyview_crtc_enable

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Jun 05, 2013 at 04:27:25PM -0300, Rodrigo Vivi wrote:
> just curious/trying to learn more: how do you know it doesn't have?

Because the hardware designers hate me and don't want to give me nice
toys :)

Seriously though, the spec doesn't have it so I have to assume it's
really gone. And we got the sprite planes in exchange. Not the best
trade in my opinion, but what can you do.

> 
> but if it doesn't feel free to use:
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> 
> On Tue, Jun 4, 2013 at 7:49 AM,  <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > VLV doesn't have the old video overlay.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index dac2db7..61bee12 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -3619,9 +3619,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)
> >         intel_enable_plane(dev_priv, plane, pipe);
> >         intel_crtc_update_cursor(crtc, true);
> >
> > -       /* Give the overlay scaler a chance to enable if it's on this pipe */
> > -       intel_crtc_dpms_overlay(intel_crtc, true);
> > -
> >         intel_update_fbc(dev);
> >
> >         mutex_unlock(&dev_priv->dpio_lock);
> > --
> > 1.8.1.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> 
> 
> -- 
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br

-- 
Ville Syrjälä
Intel OTC