From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Make intel_enable_fbc() static
Date: Mon, 24 Jun 2013 20:34:14 +0200 [thread overview]
Message-ID: <20130624183414.GK5823@phenom.ffwll.local> (raw)
In-Reply-To: <1372087322-30271-2-git-send-email-damien.lespiau@intel.com>
On Mon, Jun 24, 2013 at 04:22:01PM +0100, Damien Lespiau wrote:
> This function has no user outside of intel_pm.c.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Queued for -next, thanks for the patch. On the topic of stuff that sparse
can catch, we've accumulated a few other ones. On a quick look I think the
other non-static functions without declaration and the few enum transcoder
vs. enum pipe mismatche seem to be worth fixing. Volunteered?
-Daniel
> ---
> drivers/gpu/drm/i915/intel_drv.h | 1 -
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index ffe9d35..a165be6 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -779,7 +779,6 @@ extern int intel_sprite_get_colorkey(struct drm_device *dev, void *data,
> extern void intel_init_pm(struct drm_device *dev);
> /* FBC */
> extern bool intel_fbc_enabled(struct drm_device *dev);
> -extern void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval);
> extern void intel_update_fbc(struct drm_device *dev);
> /* IPS */
> extern void intel_gpu_ips_init(struct drm_i915_private *dev_priv);
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index b27bda0..a8483f5 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -368,7 +368,7 @@ static void intel_cancel_fbc_work(struct drm_i915_private *dev_priv)
> dev_priv->fbc_work = NULL;
> }
>
> -void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval)
> +static void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval)
> {
> struct intel_fbc_work *work;
> struct drm_device *dev = crtc->dev;
> --
> 1.8.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-06-24 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 15:22 Small FBC fix Damien Lespiau
2013-06-24 15:22 ` [PATCH 1/2] drm/i915: Make intel_enable_fbc() static Damien Lespiau
2013-06-24 18:34 ` Daniel Vetter [this message]
2013-06-24 15:22 ` [PATCH 2/2] drm/i915: Fix reason for per-chip disabling of FBC Damien Lespiau
2013-06-24 18:36 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624183414.GK5823@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox