From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Really fix the debug unregister code
Date: Mon, 8 Jul 2013 22:07:43 +0200 [thread overview]
Message-ID: <20130708200743.GI18285@phenom.ffwll.local> (raw)
In-Reply-To: <1373220233-20648-1-git-send-email-ben@bwidawsk.net>
On Sun, Jul 07, 2013 at 11:03:53AM -0700, Ben Widawsky wrote:
> This smells like a missing git add, but unregister was not handled
> properly in:
> commit c032d5491a4d8d56d8364f4919364815b55d3437
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Thu Jul 4 20:39:49 2013 +0200
>
> drm/i915: convert debugfs creation/destruction to table
>
> fops is already the pointer that we want when incrementally removing.
>
> One really bad side effect of this failure is all tests in our test
> suite will fail after module_reload fails.
>
> This fix was actually lazily authored by Chris.
>
> CC: Chris Wilson <chris@chris-wilson.co.uk>
> Reported-and-tested-by: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Fixed by merging the right version of my patch (the one you've actually
looked at ...). My apologies for the mess I've caused here.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index b49d731..d870f27 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2420,8 +2420,7 @@ void i915_debugfs_cleanup(struct drm_minor *minor)
> 1, minor);
> for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {
> struct drm_info_list *info_list =
> - (struct drm_info_list *) &i915_debugfs_files[i].fops;
> -
> + (struct drm_info_list *)i915_debugfs_files[i].fops;
> drm_debugfs_remove_files(info_list, 1, minor);
> }
> }
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-07-08 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 18:03 [PATCH] drm/i915: Really fix the debug unregister code Ben Widawsky
2013-07-08 20:07 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130708200743.GI18285@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox