Re: [PATCH 1/3] drm: use common drm_gem_dmabuf_release in i915/exynos drivers

[Daniel Vetter <daniel@ffwll.ch>]

On Wed, Aug 07, 2013 at 07:18:45PM +0900, Joonyoung Shim wrote:
> On 08/07/2013 06:55 PM, Daniel Vetter wrote:
> >On Wed, Aug 7, 2013 at 11:40 AM, Inki Dae <inki.dae@samsung.com> wrote:
> >>>-----Original Message-----
> >>>From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch]
> >>>Sent: Wednesday, August 07, 2013 6:15 PM
> >>>To: DRI Development
> >>>Cc: Intel Graphics Development; Daniel Vetter; Inki Dae
> >>>Subject: [PATCH 1/3] drm: use common drm_gem_dmabuf_release in i915/exynos
> >>>drivers
> >>>
> >>>Note that this is slightly tricky since both drivers store their
> >>>native objects in dma_buf->priv. But both also embed the base
> >>>drm_gem_object at the first position, so the implicit cast is ok.
> >>>
> >>>To use the release helper we need to export it, too.
> >>Yeah, may I repost this patch with additional work?  We also need to export
> >>with a gem object instead of specific one like you did.
> 
> I think dmabuf stuff of exynos can be replaced to common drm_gem_dmabuf.
> Already dmabuf stuff of drm_gem_cma_helper.c was substituted to common
> drm_gem_dmabuf with low-level hook functions to use prime helpers.

Ah, but that can easily be done on top of this, right?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch