From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: don't leak dp_connector at intel_ddi_init
Date: Wed, 9 Oct 2013 19:25:17 +0200 [thread overview]
Message-ID: <20131009172517.GQ8303@phenom.ffwll.local> (raw)
In-Reply-To: <1381337556-1596-1-git-send-email-przanoni@gmail.com>
On Wed, Oct 09, 2013 at 01:52:36PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Regression introduced by:
> commit 311a20949f047a70935d6591010f42336f5402e7
> Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
> drm/i915: don't init DP or HDMI when not supported by DDI port
>
> Since the commit above it is possible to have a DDI encoder that has
> the HDMI connector but not the DP connector (in case the port doesn't
> support DP). In this case, we must properly free the DP connector.
>
> We just leak this once, so it's not a big deal.
>
> Reported by kmemleak.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-10-09 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 16:52 [PATCH] drm/i915: don't leak dp_connector at intel_ddi_init Paulo Zanoni
2013-10-09 17:25 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009172517.GQ8303@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).