From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Use vlv_clock() in vlv_crtc_clock_get()
Date: Mon, 14 Oct 2013 07:44:16 -0700 [thread overview]
Message-ID: <20131014074416.0dc840c4@jbarnes-desktop> (raw)
In-Reply-To: <1381751431-29424-2-git-send-email-ville.syrjala@linux.intel.com>
On Mon, 14 Oct 2013 14:50:31 +0300
ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Avoid some code duplication.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index baa6ef6..b334c50 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5211,10 +5211,10 @@ static void vlv_crtc_clock_get(struct intel_crtc *crtc,
> clock.p1 = (mdiv >> DPIO_P1_SHIFT) & 7;
> clock.p2 = (mdiv >> DPIO_P2_SHIFT) & 0x1f;
>
> - clock.vco = refclk * clock.m1 * clock.m2 / clock.n;
> - clock.dot = 2 * clock.vco / (clock.p1 * clock.p2);
> + vlv_clock(refclk, &clock);
>
> - pipe_config->port_clock = clock.dot / 10;
> + /* clock.dot is the fast clock */
> + pipe_config->port_clock = clock.dot / 5;
> }
>
> static bool i9xx_get_pipe_config(struct intel_crtc *crtc,
Looks like this will result in the same bits.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-10-14 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 11:50 [PATCH 1/2] drm/i915: Use DIV_ROUND_CLOSEST() to calculate dot/vco ville.syrjala
2013-10-14 11:50 ` [PATCH 2/2] drm/i915: Use vlv_clock() in vlv_crtc_clock_get() ville.syrjala
2013-10-14 14:44 ` Jesse Barnes [this message]
2013-10-14 14:59 ` Daniel Vetter
2013-10-14 14:43 ` [PATCH 1/2] drm/i915: Use DIV_ROUND_CLOSEST() to calculate dot/vco Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014074416.0dc840c4@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox