public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Subject: Re: [PATCH] drm/i915: preserve dispaly init order on ByT
Date: Wed, 16 Oct 2013 19:46:27 +0200	[thread overview]
Message-ID: <20131016174627.GN4830@phenom.ffwll.local> (raw)
In-Reply-To: <1381936241-20905-1-git-send-email-dedekind1@gmail.com>

On Wed, Oct 16, 2013 at 06:10:41PM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> This patch changes HDMI port registration order for the BayTrail platform.
> 
> The story is that in kernel version 3.11 i915 supported only one HDMI port -
> the HDMIB port. So this port ended up being HDMI-1 in user-space.
> 
> But commit '6f6005a drm/i915: expose HDMI connectors on port C on BYT'
> introduced HDMIC port support. And added HDMIC  registration prior to HDMIB,
> so HDMIB became HDMI-2 and HDMIC became HDMI-1.
> 
> Well, this is fine as far as the kernel is concerned. i915 does not give any
> guarantees to the numbering, and has never given them.
> 
> However, this breaks wayland setup in Tizen IVI. We have only one single HDMI
> port on our hardware, and it is connected to HDMIB. Our configuration relies on
> the fact that it is HDMI-1.
> 
> Well, certainly this is user-space problem which was exposed with Jesse's
> patch. However, there is a reason why we have to do this assumption - we use
> touchscreen monitors and we have to associate event devices with the monitors,
> and this is not easy to do dynamically, so we just have a static setup.
> 
> Anyway, while the user-space setup will have to be fixed regardless, let's
> chane the HDMI port registration order so that HDMIB stays HDMI-1, just like it
> was in 3.11. Simply because there is no strong reason for changing the order in
> the kernel, and it'll help setups like ours in sense that we'll have more time
> for fixing the issue properly.
> 
> Also amend the commentary which looks a bit out-of-date.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

This makes imo sense irrespective of any userspace issues. Queued for
-next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2013-10-16 17:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16 15:10 [PATCH] drm/i915: preserve dispaly init order on ByT Artem Bityutskiy
2013-10-16 17:46 ` Daniel Vetter [this message]
2013-10-16 20:48   ` Chris Wilson
2013-10-17 14:03   ` Artem Bityutskiy
  -- strict thread matches above, loose matches on Subject: below --
2013-10-16 14:48 Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131016174627.GN4830@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dedekind1@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox