From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/dp: don't mention eDP bpp clamping if it doesn't affect bpp
Date: Fri, 18 Oct 2013 16:05:11 +0200 [thread overview]
Message-ID: <20131018140511.GZ4830@phenom.ffwll.local> (raw)
In-Reply-To: <1381932378-14890-1-git-send-email-jani.nikula@intel.com>
On Wed, Oct 16, 2013 at 05:06:17PM +0300, Jani Nikula wrote:
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> This is useful with the follow-up patch that frobs
> dev_priv->vbt.edp_bpp, and the value no longer comes directly from VBT.
Same as for Ben's patch: Such prep-patch justifications should imo be part
of the commit message. I've moved it.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_dp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index e4fdedc..f63aa8c 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -822,10 +822,11 @@ intel_dp_compute_config(struct intel_encoder *encoder,
> /* Walk through all bpp values. Luckily they're all nicely spaced with 2
> * bpc in between. */
> bpp = pipe_config->pipe_bpp;
> - if (is_edp(intel_dp) && dev_priv->vbt.edp_bpp) {
> + if (is_edp(intel_dp) && dev_priv->vbt.edp_bpp &&
> + dev_priv->vbt.edp_bpp < bpp) {
> DRM_DEBUG_KMS("clamping bpp for eDP panel to BIOS-provided %i\n",
> dev_priv->vbt.edp_bpp);
> - bpp = min_t(int, bpp, dev_priv->vbt.edp_bpp);
> + bpp = dev_priv->vbt.edp_bpp;
> }
>
> for (; bpp >= 6*3; bpp -= 2*3) {
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-10-18 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 14:06 [PATCH 1/2] drm/i915/dp: don't mention eDP bpp clamping if it doesn't affect bpp Jani Nikula
2013-10-16 14:06 ` [PATCH 2/2] drm/i915/dp: workaround BIOS eDP bpp clamping issue Jani Nikula
2013-10-18 6:18 ` Jani Nikula
2013-10-21 7:52 ` [PATCH for 3.12/-fixes 1/2] drm/i915: Add support for pipe_bpp readout Jani Nikula
2013-10-21 7:52 ` [PATCH for 3.12/-fixes 2/2] drm/i915/dp: workaround BIOS eDP bpp clamping issue Jani Nikula
2013-10-21 8:06 ` Daniel Vetter
2013-10-18 14:05 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018140511.GZ4830@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox