From: Daniel Vetter <daniel@ffwll.ch>
To: oscar.mateo@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4 v2] gem_flink_race: Assure no pending requests before object counting
Date: Tue, 5 Nov 2013 12:47:11 +0100 [thread overview]
Message-ID: <20131105114711.GA1775@phenom.ffwll.local> (raw)
In-Reply-To: <1383649051-6289-1-git-send-email-oscar.mateo@intel.com>
On Tue, Nov 05, 2013 at 10:57:31AM +0000, oscar.mateo@intel.com wrote:
> From: Oscar Mateo <oscar.mateo@intel.com>
>
> Same thing that was done for prime_self_import.
>
> v2: Move igt_drop_caches_set() call inside get_object_count() to make
> it clearer why we want this.
>
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
Both merged, thanks for the patches.
-Daniel
> ---
> tests/gem_flink_race.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/gem_flink_race.c b/tests/gem_flink_race.c
> index b81007e..195ec15 100644
> --- a/tests/gem_flink_race.c
> +++ b/tests/gem_flink_race.c
> @@ -35,6 +35,7 @@
> #include "drmtest.h"
> #include "i915_drm.h"
> #include "intel_bufmgr.h"
> +#include "igt_debugfs.h"
>
> /* Testcase: check for flink/open vs. gem close races
> *
> @@ -54,6 +55,8 @@ static int get_object_count(void)
> int device = drm_get_card();
> char *path;
>
> + igt_drop_caches_set(DROP_RETIRE);
> +
> ret = asprintf(&path, "/sys/kernel/debug/dri/%d/i915_gem_objects", device);
> igt_assert(ret != -1);
>
> @@ -157,9 +160,11 @@ static void test_flink_close(void)
> {
> pthread_t *threads;
> int r, i, num_threads;
> - int obj_count = get_object_count();
> + int obj_count;
> void *status;
>
> + obj_count = get_object_count();
> +
> num_threads = sysconf(_SC_NPROCESSORS_ONLN);
>
> threads = calloc(num_threads, sizeof(pthread_t));
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-11-05 11:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 16:30 [PATCH 1/4] tests: Fix "-thrashing" and "-thrash-inactive" distinction oscar.mateo
2013-11-04 16:30 ` [PATCH 2/4] lib: Add igt_drop_caches_set() oscar.mateo
2013-11-04 17:06 ` Daniel Vetter
2013-11-04 17:22 ` Mateo Lozano, Oscar
2013-11-04 17:41 ` Daniel Vetter
2013-11-04 16:30 ` [PATCH 3/4] prime_self_import: Assure no pending requests before object counting oscar.mateo
2013-11-04 17:09 ` Daniel Vetter
2013-11-05 10:56 ` [PATCH 3/4 v2] " oscar.mateo
2013-11-04 16:30 ` [PATCH 4/4] gem_flink_race: " oscar.mateo
2013-11-05 10:57 ` [PATCH 4/4 v2] " oscar.mateo
2013-11-05 11:47 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105114711.GA1775@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=oscar.mateo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox