From: Daniel Vetter <daniel@ffwll.ch>
To: "Barbalho, Rafael" <rafael.barbalho@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] tests/gem_reloc_overflow: Add gen8+ specifc tests
Date: Thu, 7 Nov 2013 14:15:40 +0100 [thread overview]
Message-ID: <20131107131540.GS14082@phenom.ffwll.local> (raw)
In-Reply-To: <20131107130555.GR14082@phenom.ffwll.local>
On Thu, Nov 07, 2013 at 02:05:55PM +0100, Daniel Vetter wrote:
> Cool, thanks for testing. Since I'm paranoid about this I've added an
> assert into the relevant fixture block to make sure the batch would really
> work safe for the condition we're testing. That way we're maximally robust
> against kernel changes that move the tests around.
>
> Also fixed some compile warnings in a follow-up.
>
> Thanks for your patch, applied to i-g-t.
Meh, I've been a bit too quick, two important fixups where needed:
- Make the subtest enumeration work (it's supposed to work without an
intel gpu present, e.g. for central build/test servers).
- Always enumerate all subtests (again to facilitate testing across
platforms).
Maybe we need some docs about this stuff, currently most of it is encoded
as runtime asserts in the test suite library.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-11-07 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 18:12 [PATCH] tests/gem_reloc_overflow: Add gen8+ specifc tests rafael.barbalho
2013-11-06 18:52 ` Daniel Vetter
2013-11-06 19:52 ` Barbalho, Rafael
2013-11-07 13:05 ` Daniel Vetter
2013-11-07 13:15 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107131540.GS14082@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rafael.barbalho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox