From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915/bdw: Add BDW to ULT macro
Date: Mon, 11 Nov 2013 19:18:11 +0100 [thread overview]
Message-ID: <20131111181811.GE14978@phenom.ffwll.local> (raw)
In-Reply-To: <1383934806-454-1-git-send-email-benjamin.widawsky@intel.com>
On Fri, Nov 08, 2013 at 10:20:06AM -0800, Ben Widawsky wrote:
> For what we care about ULT and ULX are interchangeable. We know of 3
> types of pciids for these cases. I am not sure if at some point we will
> need to distinguish ULT and ULX.
>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
I think for -next we want a is_ult flag in our info struct. On modern
platform this seems to be a much more useful disdinction than the
is_mobile stuff from the gen2/3 days we still use ;-)
Merged into bdw-fixes, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_drv.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 9944b26..8396eec 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1750,8 +1750,13 @@ struct drm_i915_file_private {
> #define IS_MOBILE(dev) (INTEL_INFO(dev)->is_mobile)
> #define IS_HSW_EARLY_SDV(dev) (IS_HASWELL(dev) && \
> ((dev)->pdev->device & 0xFF00) == 0x0C00)
> -#define IS_ULT(dev) (IS_HASWELL(dev) && \
> +#define IS_BDW_ULT(dev) (IS_BROADWELL(dev) && \
> + (((dev)->pdev->device & 0xf) == 0x2 || \
> + ((dev)->pdev->device & 0xf) == 0x6 || \
> + ((dev)->pdev->device & 0xf) == 0xe))
> +#define IS_HSW_ULT(dev) (IS_HASWELL(dev) && \
> ((dev)->pdev->device & 0xFF00) == 0x0A00)
> +#define IS_ULT(dev) (IS_HSW_ULT(dev) || IS_BDW_ULT(dev))
> #define IS_HSW_GT3(dev) (IS_HASWELL(dev) && \
> ((dev)->pdev->device & 0x00F0) == 0x0020)
> #define IS_PRELIMINARY_HW(intel_info) ((intel_info)->is_preliminary)
> --
> 1.8.4.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-11-11 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 18:20 [PATCH] drm/i915/bdw: Add BDW to ULT macro Ben Widawsky
2013-11-11 18:18 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111181811.GE14978@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox