Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/3] drm/i915: Make AGP=n work even on gen3
Date: Wed, 13 Nov 2013 20:59:56 +0200	[thread overview]
Message-ID: <20131113185956.GF7819@intel.com> (raw)
In-Reply-To: <1384158919-30592-2-git-send-email-daniel.vetter@ffwll.ch>

On Mon, Nov 11, 2013 at 09:35:17AM +0100, Daniel Vetter wrote:
> Most platforms din't hit this condition, but if we want to allow
> building without agp we should also make this allowed on gen3.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 38a344694e35..d7c922051c89 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -158,7 +158,7 @@ static struct drm_driver driver;
>  #if IS_ENABLED(CONFIG_AGP_INTEL)
>  extern int intel_agp_enabled;
>  #else
> -static int intel_agp_enabled;
> +static int intel_agp_enabled = 1;

Patch 2/3 eliminates our only use of intel_agp_enabled, so this patch
seems pointless.

>  #endif
>  
>  static const struct intel_device_info intel_i830_info = {
> -- 
> 1.8.4.rc3

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2013-11-13 18:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11  8:35 [PATCH 0/3] Deprecate legacy crap Daniel Vetter
2013-11-11  8:35 ` [PATCH 1/3] drm/i915: Make AGP=n work even on gen3 Daniel Vetter
2013-11-13 18:59   ` Ville Syrjälä [this message]
2013-11-13 20:21     ` Daniel Vetter
2013-11-13 23:24       ` Ville Syrjälä
2013-11-14  0:43         ` Daniel Vetter
2013-11-11  8:35 ` [PATCH 2/3] drm/i915: Kill legeacy AGP for gen3 kms Daniel Vetter
2013-11-13 19:00   ` Ville Syrjälä
2013-11-13 21:14   ` [PATCH] " Daniel Vetter
2013-11-13 23:20     ` Ville Syrjälä
2013-11-11  8:35 ` [PATCH 3/3] drm/i915: Deprecated UMS support Daniel Vetter
2013-11-13 19:01   ` Ville Syrjälä
2013-11-13 21:11   ` [PATCH] " Daniel Vetter
2013-11-13 23:18     ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131113185956.GF7819@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox