From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/ddi: set sink to power down mode on dp disable
Date: Thu, 21 Nov 2013 15:11:36 +0100 [thread overview]
Message-ID: <20131121141136.GN27344@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGSssEwXn+C25eZrURD_r14vUJQdFmSnWEG641zYViX4LQ@mail.gmail.com>
On Mon, Nov 18, 2013 at 02:45:47PM -0200, Paulo Zanoni wrote:
> 2013/11/15 Jani Nikula <jani.nikula@intel.com>:
> > Similar to
> > commit fdbc3b1f639bb2cbfb32c612b2699e0ba373317d
> > Author: Jani Nikula <jani.nikula@intel.com>
> > Date: Tue Nov 12 17:10:13 2013 +0200
> >
> > drm/i915/dp: set sink to power down mode on dp disable
> >
> > but for DDI, where we've never done this.
> >
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Makes sense, but I wonder if the correct place is this or
> intel_disable_ddi(), right after the call to
> ironlake_edp_backlight_off(). The current place is still better than
> nowhere, so: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> >
> > ---
> >
> > UNTESTED!
>
> I'll leave your patch applied on my tree for now. If anything explodes
> and I survive, I'll tell you :)
Picked up for -fixes, thanks for the patch.
-Daniel
>
>
> > ---
> > drivers/gpu/drm/i915/intel_ddi.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index 1591576..6a63a09 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -1158,9 +1158,10 @@ static void intel_ddi_post_disable(struct intel_encoder *intel_encoder)
> > if (wait)
> > intel_wait_ddi_buf_idle(dev_priv, port);
> >
> > - if (type == INTEL_OUTPUT_EDP) {
> > + if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) {
> > struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > ironlake_edp_panel_vdd_on(intel_dp);
> > + intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
> > ironlake_edp_panel_off(intel_dp);
> > }
> >
> > --
> > 1.7.9.5
> >
>
>
>
> --
> Paulo Zanoni
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-11-21 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 13:29 [PATCH] drm/i915/ddi: set sink to power down mode on dp disable Jani Nikula
2013-11-18 16:45 ` Paulo Zanoni
2013-11-21 14:11 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-15 13:29 Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121141136.GN27344@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox