From: Daniel Vetter <daniel@ffwll.ch>
To: "S, Deepak" <deepak.s@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915/vlv: Update Wait for FIFO and wait for 20 free entries. v2
Date: Fri, 29 Nov 2013 15:02:52 +0100 [thread overview]
Message-ID: <20131129140252.GY27344@phenom.ffwll.local> (raw)
In-Reply-To: <F359EE24E0B97E4A9739736D2C188EF3FB1EEB@BGSMSX102.gar.corp.intel.com>
On Fri, Nov 29, 2013 at 11:53:44AM +0000, S, Deepak wrote:
> Sure Chris, I will recheck the spec and change the commit accordingly.
I guess the big question is why vlv is special. We've had these 20 fifo
entries ever since gen6, so I'd also really like to know what suddenly
changed. Even the 20 entries have just been copied from a spec with no
explation. So if this is to allow hw writes to the gt from the display,
then I guess we would need this change on all gen6+ platforms?
Hence digging through specs or dragging a hw engineer into this discussion
would be highly appreciated.
Thanks, Daniel
>
> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Friday, November 29, 2013 5:07 PM
> To: S, Deepak
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/vlv: Update Wait for FIFO and wait for 20 free entries. v2
>
> On Fri, Nov 29, 2013 at 11:22:32AM +0000, S, Deepak wrote:
> > Hi Chris,
> >
> > In VLV, both hardware and software can use the write fifo in parallel, we are adding this change as a water mark to make sure we atleast have 20 free entries .This will help us to avoid software mmio write being dropped.
>
> Please think some more and describe the change exactly.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-11-29 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 10:14 [PATCH v2] drm/i915/vlv: Update Wait for FIFO and wait for 20 free entries. v2 deepak.s
2013-11-29 10:38 ` Chris Wilson
2013-11-29 11:22 ` S, Deepak
2013-11-29 11:36 ` Chris Wilson
2013-11-29 11:53 ` S, Deepak
2013-11-29 14:02 ` Daniel Vetter [this message]
[not found] ` <F359EE24E0B97E4A9739736D2C188EF3FB329A@BGSMSX102.gar.corp.intel.com>
2013-12-04 8:39 ` Daniel Vetter
2013-12-04 9:11 ` S, Deepak
[not found] ` <20131204093352.GB9481@nuc-i3427.alporthouse.com>
[not found] ` <F359EE24E0B97E4A9739736D2C188EF3FB3616@BGSMSX102.gar.corp.intel.com>
2013-12-04 11:07 ` Daniel Vetter
2013-12-04 11:22 ` S, Deepak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129140252.GY27344@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox