From: Daniel Vetter <daniel@ffwll.ch>
To: tvrtko.ursulin@linux.intel.com
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] build: Make sure asserts are enabled for tests
Date: Tue, 3 Dec 2013 17:23:43 +0100 [thread overview]
Message-ID: <20131203162343.GF27344@phenom.ffwll.local> (raw)
In-Reply-To: <1386083397-27634-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On Tue, Dec 03, 2013 at 03:09:57PM +0000, tvrtko.ursulin@linux.intel.com wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Tests depend on assertions being enabled since they can, and do,
> contain actual test steps. They are also mandatory for ensuring
> sane test case behaviour.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Merged, thanks for the patch.
-Daniel
> ---
> lib/check-ndebug.h | 3 +++
> tests/Android.mk | 2 +-
> tests/Makefile.am | 1 +
> 3 files changed, 5 insertions(+), 1 deletion(-)
> create mode 100644 lib/check-ndebug.h
>
> diff --git a/lib/check-ndebug.h b/lib/check-ndebug.h
> new file mode 100644
> index 0000000..68a6ec4
> --- /dev/null
> +++ b/lib/check-ndebug.h
> @@ -0,0 +1,3 @@
> +#ifdef NDEBUG
> +#error "Testsuite needs its asserts!"
> +#endif
> diff --git a/tests/Android.mk b/tests/Android.mk
> index 1bd3d21..ec64acd 100644
> --- a/tests/Android.mk
> +++ b/tests/Android.mk
> @@ -40,7 +40,7 @@ define add_test
> $(LIBPCIACCESS_PATH)/include
>
> LOCAL_CFLAGS += -DHAVE_STRUCT_SYSINFO_TOTALRAM
> - LOCAL_CFLAGS += -DANDROID
> + LOCAL_CFLAGS += -DANDROID -UNDEBUG -include "check-ndebug.h"
> LOCAL_CFLAGS += -std=c99
> # FIXME: drop once Bionic correctly annotates "noreturn" on pthread_exit
> LOCAL_CFLAGS += -Wno-error=return-type
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 8e293f7..b8cddd5 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -23,6 +23,7 @@ CLEANFILES = $(EXTRA_PROGRAMS)
> AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) \
> -I$(srcdir)/.. \
> -I$(srcdir)/../lib \
> + -include "check-ndebug.h" \
> -DIGT_DATADIR=\""$(abs_srcdir)"\" \
> $(NULL)
>
> --
> 1.8.4.3
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-12-03 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 15:09 [PATCH] build: Make sure asserts are enabled for tests tvrtko.ursulin
2013-12-03 16:23 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203162343.GF27344@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox