From: Damien Lespiau <damien.lespiau@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/3] tests: drm_open_any doesn't fail
Date: Fri, 6 Dec 2013 12:58:23 +0000 [thread overview]
Message-ID: <20131206125823.GC16277@strange.amr.corp.intel.com> (raw)
In-Reply-To: <1386323324-19196-1-git-send-email-daniel.vetter@ffwll.ch>
On Fri, Dec 06, 2013 at 10:48:42AM +0100, Daniel Vetter wrote:
> Or more precisely: It already has an igt_require. So we cant ditch it
> from tests.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> tests/kms_cursor_crc.c | 1 -
> tests/kms_fbc_crc.c | 1 -
> tests/kms_pipe_crc_basic.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index 74da32eb7497..b78ea7863585 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -338,7 +338,6 @@ igt_main
> const char *cmd = "pipe A none";
>
> data.drm_fd = drm_open_any();
> - igt_require(data.drm_fd >= 0);
>
> igt_set_vt_graphics_mode();
>
> diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c
> index 660086290f28..7a7f3903667b 100644
> --- a/tests/kms_fbc_crc.c
> +++ b/tests/kms_fbc_crc.c
> @@ -492,7 +492,6 @@ igt_main
> FILE *status;
>
> data.drm_fd = drm_open_any();
> - igt_require(data.drm_fd);
> igt_set_vt_graphics_mode();
>
> data.devid = intel_get_drm_devid(data.drm_fd);
> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
> index 3bc9eb0ee361..0e793cdf617d 100644
> --- a/tests/kms_pipe_crc_basic.c
> +++ b/tests/kms_pipe_crc_basic.c
> @@ -219,7 +219,6 @@ igt_main
> const char *cmd = "pipe A none";
>
> data.drm_fd = drm_open_any();
> - igt_require(data.drm_fd >= 0);
>
> igt_set_vt_graphics_mode();
>
> --
> 1.8.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2013-12-06 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 9:48 [PATCH 1/3] tests: drm_open_any doesn't fail Daniel Vetter
2013-12-06 9:48 ` [PATCH 2/3] lib: add igt_pipe_crc_check Daniel Vetter
2013-12-06 12:56 ` Damien Lespiau
2013-12-06 9:48 ` [PATCH 3/3] lib: make igt_pipe_crc_start never fail Daniel Vetter
2013-12-06 12:52 ` Damien Lespiau
2013-12-06 12:58 ` Damien Lespiau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206125823.GC16277@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox