From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Eugene Shatokhin <eugene.shatokhin@rosalab.ru>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: don't update the dri1 breadcrumb with modesetting
Date: Tue, 10 Dec 2013 14:48:23 +0100 [thread overview]
Message-ID: <20131210134823.GI9804@phenom.ffwll.local> (raw)
In-Reply-To: <20131210124412.GE10793@nuc-i3427.alporthouse.com>
On Tue, Dec 10, 2013 at 12:44:12PM +0000, Chris Wilson wrote:
> On Tue, Dec 10, 2013 at 01:24:01PM +0100, Daniel Vetter wrote:
> > The update is horribly racy since it doesn't protect at all against
> > concurrent closing of the master fd. And it can't really since that
> > requires us to grab a mutex.
> >
> > Instead of jumping through hoops and offloading this to a worker
> > thread just block this bit of code for the modesetting driver.
> >
> > Reported-by: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
> > Cc: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> We should also not be calling update_dri1_breadcrumb unless we have a
> USER_INTERRUPT. The other updates to the breadcrumb hws index do not
> appear to be serialised by anything other than polling.
Well, this is what's been there before and I don't really want to touch
dri1/ums code at all. So I think we'll just keep this here until we'll all
put it on the big pyre ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-12-10 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 12:24 [PATCH] drm/i915: don't update the dri1 breadcrumb with modesetting Daniel Vetter
2013-12-10 12:44 ` [Intel-gfx] " Chris Wilson
2013-12-10 13:48 ` Daniel Vetter [this message]
2013-12-11 11:06 ` Daniel Vetter
2013-12-11 13:04 ` Eugene Shatokhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210134823.GI9804@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=eugene.shatokhin@rosalab.ru \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox