From: Damien Lespiau <damien.lespiau@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/8] drm/i915: Make the intel_device_info structure kept in dev_priv writable
Date: Thu, 12 Dec 2013 15:38:05 +0000 [thread overview]
Message-ID: <20131212153805.GA14545@strange.amr.corp.intel.com> (raw)
In-Reply-To: <87y53q84u1.fsf@intel.com>
On Thu, Dec 12, 2013 at 05:30:14PM +0200, Jani Nikula wrote:
> > -#define INTEL_INFO(dev) (to_i915(dev)->info)
> > +#define INTEL_INFO(dev) ((const struct intel_device_info *)&to_i915(dev)->info)
>
> If that were an inline function you wouldn't have to cast to add const:
>
> static inline const struct intel_device_info *
> intel_info(const struct drm_device *dev)
> {
> return to_i915(dev)->info;
> }
>
> I'm not insisting on this bikeshed, though.
True, I'd happily review a follow-up patch once the series has landed :)
--
Damien
next prev parent reply other threads:[~2013-12-12 15:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 14:36 Supporting fused display configurations v3 Damien Lespiau
2013-12-12 14:36 ` [PATCH 1/8] drm/i915: Use IS_VALLEYVIEW() to test the is_valleyview flag Damien Lespiau
2013-12-17 9:38 ` Daniel Vetter
2013-12-17 11:17 ` Damien Lespiau
2013-12-17 12:18 ` Daniel Vetter
2013-12-12 14:36 ` [PATCH 2/8] drm/i915: Always use INTEL_INFO() to access the device_info structure Damien Lespiau
2013-12-12 16:58 ` Chris Wilson
2013-12-12 17:05 ` Damien Lespiau
2013-12-12 17:23 ` Chris Wilson
2013-12-12 18:47 ` Ville Syrjälä
2013-12-12 14:36 ` [PATCH 3/8] drm/i915: Make the intel_device_info structure kept in dev_priv writable Damien Lespiau
2013-12-12 15:30 ` Jani Nikula
2013-12-12 15:38 ` Damien Lespiau [this message]
2013-12-12 16:58 ` Ville Syrjälä
2013-12-12 14:36 ` [PATCH 4/8] drm/i915: Move num_plane to the intel_device_info structure Damien Lespiau
2013-12-12 14:36 ` [PATCH 5/8] drm/i915: Consolidate FUSE_STRAP in one set of defines Damien Lespiau
2013-12-12 14:36 ` [PATCH 6/8] drm/i915: Disable display when fused off Damien Lespiau
2013-12-12 14:36 ` [PATCH 7/8] drm/i915: Remove the Quanta special case Damien Lespiau
2013-12-12 14:36 ` [PATCH 8/8] drm/i915: Use I915_MAX_PIPES in the pipe/plane_to_crtc_mapping definitions Damien Lespiau
2013-12-13 8:51 ` Supporting fused display configurations v3 Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212153805.GA14545@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox