From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Ben Widawsky <benjamin.widawsky@intel.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 00/17] Broadwell HW semaphores
Date: Sat, 14 Dec 2013 11:39:27 -0800 [thread overview]
Message-ID: <20131214193926.GA15994@bwidawsk.net> (raw)
In-Reply-To: <20131214090847.GE1403@nuc-i3427.alporthouse.com>
On Sat, Dec 14, 2013 at 09:08:47AM +0000, Chris Wilson wrote:
> On Fri, Dec 13, 2013 at 08:15:48PM -0800, Ben Widawsky wrote:
> > Ben Widawsky (17):
> > drm/i915: Reorder/respace MI instruction definition
> > drm/i915: Don't emit mbox updates without semaphores
> > drm/i915: Move semaphore specific ring members to struct
> > drm/i915: Virtualize the ringbuffer signal func
> > drm/i915: Move ring_begin to signal()
> > drm/i915: Make semaphore updates more precise
> > drm/i915: gen specific semaphore info
> > drm/i915: Create for_all_rings
> > drm/i915: init ring->id early
> > drm/i915/bdw: implement semaphore signal
> > drm/i915/bdw: implement semaphore wait
> > drm/i915: FORCE_RESTORE for gen8 semaphores
> > drm/i915/bdw: poll semaphores
> > drm/i915: Extract semaphore error collection
> > drm/i915/bdw: collect semaphore error state
> > drm/i915: unleash semaphores on gen8
> > drm/i915: semaphore debugfs
>
> By the end, don't you use a mix of tables and formula for writing the
> offsets for the wait/signal commands? Looks very inconsistent when there
> is a very simple routine for generating the appropriate semaphore slot
> given (waiter, signaller).
> -Chris
>
Excluding debugfs, which was left intentionally that way...
The only inconsistency, I think was in the error state capture,
right? That was a last minute addition probably after I should have quit
for the day. Do you see something other than error state (and debugfs)?
I'll discuss the error state stuff with on the patch itself.
P.S. given our history on how to implement semaphore updates, I very
much appreciate your grace.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-12-14 19:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 4:15 [PATCH 00/17] Broadwell HW semaphores Ben Widawsky
2013-12-14 4:15 ` [PATCH 01/17] drm/i915: Reorder/respace MI instruction definition Ben Widawsky
2013-12-14 4:15 ` [PATCH 02/17] drm/i915: Don't emit mbox updates without semaphores Ben Widawsky
2013-12-14 4:15 ` [PATCH 03/17] drm/i915: Move semaphore specific ring members to struct Ben Widawsky
2013-12-14 4:15 ` [PATCH 04/17] drm/i915: Virtualize the ringbuffer signal func Ben Widawsky
2013-12-14 4:15 ` [PATCH 05/17] drm/i915: Move ring_begin to signal() Ben Widawsky
2013-12-14 9:05 ` Chris Wilson
2013-12-14 18:42 ` Ben Widawsky
2013-12-14 19:27 ` [PATCH 05/17] [v2] " Ben Widawsky
2013-12-14 4:15 ` [PATCH 06/17] drm/i915: Make semaphore updates more precise Ben Widawsky
2013-12-14 4:15 ` [PATCH 07/17] drm/i915: gen specific semaphore info Ben Widawsky
2013-12-14 4:17 ` Ben Widawsky
2013-12-14 5:46 ` [PATCH 07/17] [v2] drm/i915: gen specific ring init Ben Widawsky
2013-12-14 4:15 ` [PATCH 08/17] drm/i915: Create for_all_rings Ben Widawsky
2013-12-14 4:15 ` [PATCH 09/17] drm/i915: init ring->id early Ben Widawsky
2013-12-14 21:45 ` Chris Wilson
2013-12-15 1:42 ` Ben Widawsky
2013-12-15 9:24 ` Chris Wilson
2013-12-15 20:13 ` Ben Widawsky
2013-12-14 4:15 ` [PATCH 10/17] drm/i915/bdw: implement semaphore signal Ben Widawsky
2013-12-14 4:15 ` [PATCH 11/17] drm/i915/bdw: implement semaphore wait Ben Widawsky
2013-12-14 4:16 ` [PATCH 12/17] drm/i915: FORCE_RESTORE for gen8 semaphores Ben Widawsky
2013-12-14 4:16 ` [PATCH 13/17] drm/i915/bdw: poll semaphores Ben Widawsky
2013-12-14 4:16 ` [PATCH 14/17] drm/i915: Extract semaphore error collection Ben Widawsky
2013-12-14 4:16 ` [PATCH 15/17] drm/i915/bdw: collect semaphore error state Ben Widawsky
2013-12-14 19:47 ` Ben Widawsky
2013-12-14 21:38 ` Chris Wilson
2013-12-15 1:48 ` Ben Widawsky
2013-12-15 9:18 ` Chris Wilson
2013-12-15 20:07 ` [PATCH 15/17] [v3] " Ben Widawsky
2013-12-14 4:16 ` [PATCH 16/17] drm/i915: unleash semaphores on gen8 Ben Widawsky
2013-12-14 4:16 ` [PATCH 17/17] drm/i915: semaphore debugfs Ben Widawsky
2013-12-14 9:08 ` [PATCH 00/17] Broadwell HW semaphores Chris Wilson
2013-12-14 19:39 ` Ben Widawsky [this message]
2013-12-14 21:16 ` Chris Wilson
2013-12-14 21:25 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214193926.GA15994@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox