From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/6] drm/i915/vlv: move DPIO init earlier v2
Date: Mon, 16 Dec 2013 16:02:38 -0800 [thread overview]
Message-ID: <20131216160238.21b13005@jbarnes-desktop> (raw)
In-Reply-To: <20131214104736.GI9804@phenom.ffwll.local>
On Sat, 14 Dec 2013 11:47:36 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Dec 12, 2013 at 12:41:56PM -0800, Jesse Barnes wrote:
> > It's needed for early mode state readout, which is in turn needed to
> > inherit the BIOS config. So split out the reset, which we need on
> > resume too, from the DPIO reg init, and do the latter earlier.
> >
> > v2: split reset and reg init
> >
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> Isn't this a fixup due to the slight init reordering you do in patch 2? If
> so we need to get this one in first, and I'd also prefer if the init
> reordering is split out as a separate patch from patch 2 - that stuff
> almost always ends up hurting us in some way or the order, so a minimal
> patch as an obvious bisect point is imo worth it.
>
> With those prep patches split out I could also start merging to get this
> sucker moving finally.
Sure, done.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-12-17 0:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 20:41 [PATCH 1/6] drm/i915: unconditionally copy mode into crtc at boot time Jesse Barnes
2013-12-12 20:41 ` [PATCH 2/6] drm/i915: retrieve current fb config into new plane_config structure at init Jesse Barnes
2013-12-14 11:01 ` Daniel Vetter
2013-12-17 0:01 ` Jesse Barnes
2013-12-17 8:38 ` Daniel Vetter
2013-12-17 21:04 ` Jesse Barnes
2013-12-17 21:19 ` Daniel Vetter
2013-12-12 20:41 ` [PATCH 3/6] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7 Jesse Barnes
2013-12-12 22:54 ` Daniel Vetter
2013-12-12 23:45 ` Jesse Barnes
2013-12-13 19:09 ` Jesse Barnes
2013-12-13 20:47 ` Daniel Vetter
2013-12-14 0:43 ` Jesse Barnes
2013-12-14 10:44 ` Daniel Vetter
2013-12-14 11:33 ` Daniel Vetter
2013-12-14 11:13 ` Daniel Vetter
2013-12-14 11:36 ` Daniel Vetter
2014-02-05 14:57 ` Jesse Barnes
2013-12-12 20:41 ` [PATCH 4/6] drm/i915: don't memset the fb buffer if preallocated Jesse Barnes
2013-12-14 11:28 ` Daniel Vetter
2013-12-17 0:17 ` Jesse Barnes
2013-12-17 7:56 ` Daniel Vetter
2013-12-12 20:41 ` [PATCH 5/6] drm/i915/vlv: move DPIO init earlier v2 Jesse Barnes
2013-12-14 10:47 ` Daniel Vetter
2013-12-17 0:02 ` Jesse Barnes [this message]
2013-12-12 20:41 ` [PATCH 6/6] drm/i915: inform drm_fb_helper if we abandoned a connected output Jesse Barnes
2013-12-12 22:30 ` Chris Wilson
2013-12-12 22:34 ` Jesse Barnes
2013-12-17 0:18 ` Jesse Barnes
2013-12-12 21:21 ` [PATCH 1/6] drm/i915: unconditionally copy mode into crtc at boot time Daniel Vetter
2013-12-12 21:29 ` Jesse Barnes
2013-12-12 22:39 ` Daniel Vetter
2013-12-12 22:44 ` Jesse Barnes
2013-12-12 23:04 ` Daniel Vetter
2013-12-17 0:35 ` Jesse Barnes
2013-12-17 8:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216160238.21b13005@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox