Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 8/8] drm/i915: Provide a command line option to disable display
Date: Mon, 10 Feb 2014 10:13:52 +0100	[thread overview]
Message-ID: <20140210091352.GN17001@phenom.ffwll.local> (raw)
In-Reply-To: <1391800374-24904-9-git-send-email-damien.lespiau@intel.com>

On Fri, Feb 07, 2014 at 07:12:54PM +0000, Damien Lespiau wrote:
> If we can't actually determine at run-time we have a fused-off display,
> provide at least an option to disable it.
> 
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_dma.c    | 3 ++-
>  drivers/gpu/drm/i915/i915_drv.h    | 1 +
>  drivers/gpu/drm/i915/i915_params.c | 4 ++++
>  3 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 283ace8..493c9ea 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -1497,7 +1497,8 @@ static void intel_device_info_runtime_init(struct drm_device *dev)
>  		 * On CPT/PPT, we can detect this case as SFUSE_STRAP_FUSE_LOCK
>  		 * should be set when taking over after the firmware.
>  		 */
> -		if (fuse_strap & ILK_INTERNAL_DISPLAY_DISABLE ||
> +		if (i915.disable_display ||

tbh I'd move this out into a separate top-level check - this option is a
bit hard to catch in the fuse checks here. Alos that way I could have
merged it already ;-)

Previous two patches are also merged, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-02-10  9:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 19:12 Supporting fused display configurations v5 Damien Lespiau
2014-02-07 19:12 ` [PATCH 1/8] drm/i915: Always use INTEL_INFO() to access the device_info structure Damien Lespiau
2014-02-07 19:12 ` [PATCH 2/8] drm/i915: Make the intel_device_info structure kept in dev_priv writable Damien Lespiau
2014-02-10  9:09   ` Daniel Vetter
2014-02-10 12:49     ` Jani Nikula
2014-02-10 12:53     ` Ville Syrjälä
2014-02-10 14:06       ` Damien Lespiau
2014-02-10 14:17         ` Ville Syrjälä
2014-02-10 16:54           ` Daniel Vetter
2014-02-10 16:55       ` Daniel Vetter
2014-02-07 19:12 ` [PATCH 3/8] drm/i915: Move num_plane to the intel_device_info structure Damien Lespiau
2014-02-07 19:12 ` [PATCH 4/8] drm/i915: Consolidate FUSE_STRAP in one set of defines Damien Lespiau
2014-02-07 19:12 ` [PATCH 5/8] drm/i915: Disable display when fused off Damien Lespiau
2014-02-10  9:12   ` Daniel Vetter
2014-02-10 17:19     ` [PATCH 5/8 v5] " Damien Lespiau
2014-02-07 19:12 ` [PATCH 6/8] drm/i915: Use I915_MAX_PIPES in the pipe/plane_to_crtc_mapping definitions Damien Lespiau
2014-02-07 19:12 ` [PATCH 7/8] drm/i915: Reorder i915_params fields to not create holes Damien Lespiau
2014-02-07 19:12 ` [PATCH 8/8] drm/i915: Provide a command line option to disable display Damien Lespiau
2014-02-10  9:13   ` Daniel Vetter [this message]
2014-02-10 17:20     ` [PATCH 8/8 v2] " Damien Lespiau
2014-02-10 18:24       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210091352.GN17001@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox